[b25]Inconsistent behaviour in quest log for starting zones

[haenlomal]

Defect Summary:
Inconsistent behaviour observed in quest status for starting quests.

Steps to Replicate:
1. Start a new game as a human or halfling. Optionally, clear out Trollmire and Kor-Pul.
2. Instead of clearing out the next tier of starting zones, go and clear out the Scintillating Caves and/or the Rhaloren Camp.
3. Observe that the quest "Echoes of the Spellblaze" (the Shaloren starting quest) is granted on the death of the Boss in either zone, and that the completed message for the appropriate zone appears.
4. Go and clear out norgos lair and/or Heart of the Gloom. Observe what happens when the boss is killed.

Expected Results:
The quest "Madness of the ages" (the Thaloren starting quest) appears in the quest log, along with the completion text for whichever boss was killed. Though whether or not this is "expected behaviour" is debatable (see Comments.)

Observed Results:
No such quest update is observed.

Comments:
The cause for this behaviour is quite obvious: The on_die event hook for the Sharloren starting quest has a grantQuest command just before the setQuestStatus command, while the Thaloren simply has the setQuestStatus command.

What is more debatable is the expected proper behaviour: should non-Shaloren players be able to see the new quest entry on killing the Crystal or the Inquisitor? My gut feeling would be no. In that case, simply removing the grantQuest command will make the behaviour consistent across the board.

-- The Haen.

[darkgod]

Indeed

[haenlomal]

I noticed that you went the route of taking out the grantQuest code. In order for that to be consistent, you'll also need to take out the grantQuest code on the on_kill event hooks for Prox the Troll and the Shade (in Kor-Pul). Otherwise, a (say) Sharlore Fighter may clear out his start zone, come to the Trollmire, kill Prox, and suddenly get the quest entries for the Allied nations....

Edit: Saw that you've fixed this too. Thank!