Beta 6: Shield Wall

[SerPounce]

When I activate shield wall in Beta 6 my damage goes to negative several thousand. Beta 5 didn't really work for me (no loading), but this wasn't the case with Beta 4.

Loving the game! Thanks for all the great work!

[greycat]

Confirmed: Shield Wall is very broken. Level 5 Ghoul Fighter. Without Shield Wall active, I have Attack (main hand): 32 and Damage (main hand): 21. With Shield Wall, I have Attack (main hand): 22 and Damage (main hand): -2147483648. (I might be wrong on the last couple digits; they overlap the "Ar" in "Armor" in the next column.)

Not just a display issue either. When I attack things with Shield Wall active, I do no damage to them. Was kinda hoping it would wrap around and cause billions of damage, but alas....

The game/modules/tome/data/talents/techniques/weaponshield.lua file is unchanged, so the bug probably lies elsewhere. A quick glance showed this:

Code: Select all

			atk = self:addTemporaryValue("combat_dam", -10),
			dam = self:addTemporaryValue("combat_atk", -10),

which looks like it's switched around, but it was also switched in beta5.

Saving & loading with Shield Wall active doesn't change anything. Switching dam = and atk = in the code doesn't change anything either, unless I just don't know what to do afterward. (I tried "gmake" again.)

Lua's a big mystery to me, unfortunately.

[darkgod]

Yes I saw and fixed it earlier, it was due to the changing of the damage formula, it really did not like being handled negative damage

[SerPounce]

There appears to be a similar calculation error for the [C]haracter screen damage while using rapid shot. It doesn't appear to impact damage from shooting the bow so it's not a really a problem, but it's a bit odd to see -2xxxx on the character screen for damage.

At some point it would of course be nice to list the ranged damage for bows in the character screen either instead of or in addition to melee damage.