[1.7 b2] alterTalentLevelRaw bugs (Adept, Metaflow)

Where bugs go to lie down and rest

Moderator: Moderator

Post Reply
Message
Author
minmay
Wyrmic
Posts: 286
Joined: Fri Sep 07, 2012 1:34 am
Contact:

[1.7 b2] alterTalentLevelRaw bugs (Adept, Metaflow)

#1 Post by minmay »

1. alterTalentLevelRaw doesn't work on talent passives granted by the "passives" function (or similar places). This results in the ridiculous situation where an actor with Adept has a character sheet claiming, for example, that their Thick Skin talent is giving them 10% all resistance (effective talent level 3) when it's actually giving them only 4% (effective talent level 1).

2. Similarly, it does not account for the many talents that use on_learn and on_unlearn to grant their passive effects. The exemption for no_unlearn_last talents seems to be an attempt to hack around this issue (and frankly ought to be considered a bug in itself, as it renders Adept awful for the exact talents you'd expect Adept to be most useful for, like the Possession category and Dark Gifts). However, there are many talents without no_unlearn_last that still have on_learn/unlearn effects. For example, nearly all Wyrmic talents do this. So even this compromised implementation of Adept still has issues with those.


My suggested fix is to make Adept increase effective talent level by 2*mastery, instead of this odd "increase raw talent level but not really" thing. Talents are already designed to account for effective level changes because of mastery's existence; the same can't be said of raw level changes. This way you don't have to worry about how it interacts with no_unlearn_last, on_learn, on_unlearn, passives, the levelup screen, etc.
Same goes for Metaflow and any other sources of this mechanic, obviously.

Post Reply