[1.5.10] Graphical issues when there's water

[OhTheFolly]

(I'm putting this in a separate topic because the wide images were messing up reading the other one)

Whenever there's water I was seeing stuff like this:



I found the opengl shader setting that says to turn it off if you're having graphics issues. With it off I got this (with show grid turned off):



Much better even though I didn't want a grid, but unfortunately turning that setting off also messed up the level up screen somehow:



So I had to turn that setting back on again.

It only seems to affect areas where there's water for some reason.
Everywhere there isn't water ToME looks just like it's supposed to, so it doesn't make the game unplayable or anything.

Only serious issue it's caused is that it actually made a town invisible, so it was a bit lucky that I actually found it.
(Last Hope is the tile right underneath that patrol near the graveyard):

[HousePet]

Known issue. See if you can find the existing thread.

[Cathbald]

Changing tilesize can also fix the problem if disabling opengl isn't ok for you

[OhTheFolly]

Now that I know to search for it, I have found a practically flawless solution thanks to this wonderful post by BugReporter.

Following the steps in that post, it was the water.frag that was the culprit. Putting that in the water_test addon fixed the problem completely.

And there's no side effects! That weird black grid from the second image doesn't show up. And the level up screen isn't messed up either.

Water isn't animated anymore, of course, but that's a small price to pay as otherwise this is perfect!

Now the only issue is that the character I'm playing doesn't have the water_test addon. I tried adding it to the character's desc.lua using some instructions I found, but got some message about "switching to offline because of missing addon hash".

How do I add the water_test addon to my existing character without being put to offline mode?

[HousePet]

You can't.

[OhTheFolly]

Well that's unfortunate.

Is there any other testing I could do to help narrow down the exact cause even farther? I've noticed from other topics that this problem has been around for over a year and seems to affect a number of people. I'm willing to help out with testing so the root cause can get figured out.

[HousePet]

The other thread would make more sense for that question.

[BugReporter]

Following the steps in that post, it was the water.frag that was the culprit. Putting that in the water_test addon fixed the problem completely.

Thank you very much for testing that.

Is there any other testing I could do to help narrow down the exact cause even farther?

Skip the following if that question is for devs and not for water_test addon.
It's good that only one file (water.frag) causes the issue. As I mentioned before, I've never seen this bug on my system, hence I can only provide modified versions of that file for a person affected by this bug to test. I can't guarantee a result. Let me know if you are fine with that and I'll try to create something to test.

[OhTheFolly]

Yeah, I figure the reason this problem is still in the game is because no one who knows how to look into it can actually see the problem in action. So I'd like to test things and try to get to the bottom of what's going wrong.