HiddenBlade+assasinate apply twice the same bleeding

Where bugs go to lie down and rest

Moderator: Moderator

Post Reply
Message
Author
ghostbuster
Uruivellas
Posts: 617
Joined: Mon Oct 09, 2006 7:47 pm

HiddenBlade+assasinate apply twice the same bleeding

#1 Post by ghostbuster »

Looking at the hidden blade/assassinate code in cunning/Artifice, I noticed that there is dual application of the same bleed damage.

in hiddenblade

Code: Select all

newTalent{
        name = "Hidden Blades",
         ...
        callbackOnCrit = function(self, t, kind, dam, chance, target)
                       ...
                        local oldlife = target.life
                        ...
                        if self:knowTalent(self.T_ASSASSINATE) then
                                local scale = nil
                                scale = self:callTalent(self.T_ASSASSINATE, "getBleed") 
                                local life_diff = oldlife - target.life
                                if life_diff > 0 and target:canBe('cut') and scale then
                                        target:setEffect(target.EFF_CUT, 5, {power=life_diff * scale / 5, src=self})
                                end
                        end
                        self:startTalentCooldown(t)
         ...
}
So hidden blade calls assassinate (if it is known), then applies a bleeding based on the life difference
But in assassinate....

Code: Select all

newTalent{
        name = "Assassinate",
      ...
       action = function(self, t)
                ...
                local bleed = t.getBleed(self, t)
                local oldlife = target.life
                ...
                local do_attack = function() self:attackTarget(target, nil, t.getDamage(self, t), true, true) end
                ....                
                local life_diff = oldlife - target.life
                if life_diff > 0 and target:canBe('cut') and bleed then
                        target:setEffect(target.EFF_CUT, 5, {power=life_diff * bleed / 5, src=self})
                end

                return true
        end,
...
}:
... there is an attack and then the very same bleeding is also applied.

I assume this an error.

jenx
Sher'Tul Godslayer
Posts: 2263
Joined: Mon Feb 14, 2011 11:16 pm

Re: HiddenBlade+assasinate apply twice the same bleeding

#2 Post by jenx »

Interesting....I'm going to roll a rogue and check this out.
MADNESS rocks

Razakai
Uruivellas
Posts: 889
Joined: Tue May 14, 2013 3:45 pm

Re: HiddenBlade+assasinate apply twice the same bleeding

#3 Post by Razakai »

Not an error. The passive part of Assassinate causes Hidden Blades to inflict bleeding - and Assassinate is an attack using your Hidden Blades, and therefore causes it to bleed.

Post Reply