[1.5.1] Chants from escorts reduce native mastery

[pfhyyhtsche]

Native Celestial/Chants users (Sun Paladin/Anorithil) currently have their mastery for all chant sustains reduced from 1.3 to the escort talent value of 0.8 if they take a chant generic point reward from the Sun Paladin escort. This issue was present in the original addon chants version as well.

[HousePet]

Had a look at the code, and the mastery change for getting a point from an escort quest looks like it should be reset by the Chant Acolyte talent.

[HousePet]

Testing in game suggests it doesn't though. :/

[HousePet]

I'd also like to add that if you get a point from an escort quest, Chant Acolyte does not acknowledge its existence with the numbers it displays.

[metagaming]

I can confirm chants-chants mastery getting set to 0.8 from the escort.
I can also confirm Chant Acolyte's description not updating with the new talent point from the escort.

In addition, using a category point to increase Chants mastery does update the mastery for chants-chants (back up to 1.5 for both).

[HousePet]

Bumpage.

[rickynumber24]

A further related bug:
The Sun Paladin escort quest offers points in "Chant of Fortitude" or "Chant of Resistance". As these abilities no longer exist, accepting one of those rewards rewards you with nothing.

[ster]

A further related bug:
The Sun Paladin escort quest offers points in "Chant of Fortitude" or "Chant of Resistance". As these abilities no longer exist, accepting one of those rewards rewards you with nothing.

Uh what? If you don't have the talent it gives you it. If you do i think it increases the mastery of that specific chant (if it wasn't bugged)

[HousePet]

They do exist and it does give them to you.

[rickynumber24]

A further related bug:
The Sun Paladin escort quest offers points in "Chant of Fortitude" or "Chant of Resistance". As these abilities no longer exist, accepting one of those rewards rewards you with nothing.

Uh what? If you don't have the talent it gives you it. If you do i think it increases the mastery of that specific chant (if it wasn't bugged)

I have an Anorithil. The Chants category no longer has "Chant of X" talents. (I was also under the impression that the effect of the chant was different from the one described on my action bar.) However, my quest log says I selected the talent Chant of Fortress.

On rechecking, it does look like I do actually have 2 points in Chant of Fortress as compared to 1 in the others now... and it appears to have dropped down to the 0.8 multiplier. The hidden talents make sense now that I think about it, but it's definitely not behavior one would expect, I'd say.

[metagaming]

The reason this occurs is that the escort quest (in data/chats/escort-quest.lua) calls game.player:knowTalentType(t.type[1]) to see if the player actor knows the category.
If it is nil, the mastery is changed to 0.8, and then it gives the talent.
Otherwise, it just gives the talent.

knowTalentType() (in engine/interface/ActorTalents) is just a redirect, as seen here:

Code: Select all

function _M:knowTalentType(name)
	return self.talents_types[name]
end

The problem stems from the fact that the chant talents themselves are in celestial/chant-chants, NOT celestial/chants.
Therefore, since Sun Paladin and Anorithil don't have those categories in their birth descriptions, knowTalentType() returns nil when called on the category of celestial/chant-chants talents. Their mastery is then set to 0.8 when they take the sun paladin escort's talent rewards since nil was returned.

This may require a different solution than was used in the patch (the "passives" function in Chant/Hymn Acolyte).


I do have an add-on that sort of fixes this bug, but it's not as elegant as the patch tried to be.