Auto-assign-off option and mana bars.

[senon]

Start a new Cornac Arcane Blade with auto-assign-skills disabled. You'll find yourself with a mana bar and no skills that use mana.

Start a new Cornac Arcane Blade with auto-assign-skills enabled. Remove all points from skills before starting. You won't have a mana bar.

All credit to SubtleWolf and Effigy for finding this weird little bug.

[Effigy]

I wouldn't be surprised if this applies to other resource bars as well, but we were able to reproduce it with mana at least. I think the current behavior with auto-assign enabled is best.

[magelike]

I wrote the patch for that option a few years ago. Initially, it was intentional behavior because we thought it would be weird for classes like Arcane Blade to not have a mana pool because magic is integral to the class design. This might have been before Zigur, I don't remember. There should be some consistency here though.

This is the first time I've looked at the code in forever, but I think this is the only changed needed:

Birther.lua

Code: Select all

                        self.actor:learnPool(talent)
                        print("[BIRTHER] Ignoring auto-assign for " .. t_id .. " (from " .. d.type .. " descriptor \"" .. d.name .. "\")")
                        d.talents[t_id] = nil

to

Code: Select all

                        print("[BIRTHER] Ignoring auto-assign for " .. t_id .. " (from " .. d.type .. " descriptor \"" .. d.name .. "\")")
                        d.talents[t_id] = nil

That will make it so having auto-assign talent points at birth disabled will not automatically add resource pools to characters unless they choose a talent that uses the resource.

Alternately, we can force all magically-inclined classes to learn their resource pools at birth, but it should be one or the other.