zone.lue level_adjust_level

Where bugs go to lie down and rest

Moderator: Moderator

Post Reply
Message
Author
Dienes
Wayist
Posts: 27
Joined: Wed Jan 07, 2015 7:51 pm

zone.lue level_adjust_level

#1 Post by Dienes »

I was diving into source files trying to figure out an unrelated issue I noticed an inconsistency with _M:level_adjust_level(level, type) in te4 engine/Zone.lua line 192 versus how its often called. I ran it past Shibari on irc and they agreed it was probably a bug and I should post here about it. For example in te4 engine/Zone.lua line 208 is

Code: Select all

local lev = self:level_adjust_level(level, self, type) + (add_level or 0)
Specifically the 2 arguments vs 3 _M:level_adjust_level(level, type) vs self:level_adjust_level(level, self, type). my amateur guess is at one point it was _M:level_adjust_level(level, zone, type) and not every call was updated.

Searching te4-1.3.3.team and tome-1.3.3.team turns up
  • te4-1.3.3.team engine/Zone.lua line 208
  • tome-1.3.3.team tome\data\damage_types.lua line 616
  • tome-1.3.3.team tome\data\general\events\damp-cave.lua line 34
  • tome-1.3.3.team tome\data\general\events\drake-cave.lua line 41
  • tome-1.3.3.team tome\data\general\events\fearscape-portal.lua line 49
  • tome-1.3.3.team tome\data\general\events\naga-portal.lua line line 51
  • tome-1.3.3.team tome\data\general\events\old-battle-field.lua line 47
  • tome-1.3.3.team tome\data\general\events\rat-lich.lua line 97
  • tome-1.3.3.team tome\data\timed_effects\floor.lua lines 57, 99, 109, 129
  • tome-1.3.3.team tome\mod\class\GameState.lua lines 1477, 1482, 1534
Additionally tome\data\zones\blighted-ruins\zone.lua line 27 and tome\data\zones\grushnak-pride\zone.lua line 34 should be looked at to see if they are correct. I don't know enough to tell.

Post Reply