[git] active talents do nothing?

[greycat]

Updated git moments ago. Started a Marauder. Chose talents, started playing.

Pressing the hot key buttons for Skullcracker, Dirty Fighting or Dual Strike does absolutely nothing, other than displaying a message saying that I'm using the talent. Stamina is not consumed, and time does not pass, and the monster is never targeted nor hit by anything.

Toggling "quick melee targetting" does nothing, either. (I started with it disabled.)

[Doctornull]

Post your GIT checksum so the devs know which revision you're reporting.

[greycat]

Then I saved, exited, and re-ran the program. Started a Shalore Anorithil. Got skills, went down the stairs.

At first things seemed OK. I was able to activate my shield rune, and my hymn of shadows. When I fought the first nagas, I was able to target my moonlight ray where I wanted.

But shortly after that (perhaps when the first naga died?) the game started auto-targeting everything. Even searing light when there was no monster anywhere in sight. I still have "quick melee targetting" disabled, and I certainly don't want the game firing all my spells at squares of its choosing!

Post your GIT checksum so the devs know which revision you're reporting.

Most recent commit in "git log" other than my own merge is this one:

Code: Select all

commit 477bd36cc0b749c8f31f02bc2b1edc6103f7f742
Author: DarkGod <darkgod@net-core.org>
Date:   Wed Oct 23 11:24:02 2013 +0200

    test

Playing a bit more... it seems that what's happening is all my spells are being fired at one specific spot on the level, no matter where I am, no matter what spell I use, no matter what monsters are on the screen. The game has chosen to fire them all at that spot, period.

I wonder if it was trying to do the same thing with the Marauder's talents, and they were all simply failing immediately due to my not being adjacent to whatever spot it was targeting.

[greycat]

Reloading the saved marauder, I walked around a bit until I found a monster, got up next to it, and pressed 2 for Dirty Fighting. This immediately generated a Lua error. I "sent" it as a report, but here it is for the forum:

Code: Select all

[LOG]	Chumley uses Dirty Fighting.
stack traceback:
	[C]: in function 'error'
	/engine/interface/ActorTalents.lua:152: in function </engine/interface/ActorTalents.lua:134>
Lua Error: /engine/interface/ActorTalents.lua:174: /engine/interface/ActorTalents.lua:152: /engine/interface/ActorTalents.lua:145: attempt to index upvalue 'force_target' (a nil value)
stack traceback:
	/engine/interface/ActorTalents.lua:145: in function 'getTarget'
	/data/talents/cunning/dirty.lua:36: in function </data/talents/cunning/dirty.lua:34>
	[C]: in function 'xpcall'
	/engine/interface/ActorTalents.lua:147: in function </engine/interface/ActorTalents.lua:134>
	At [C]:-1 
	At [C]:-1 error
	At /engine/interface/ActorTalents.lua:174 useTalent
	At /engine/interface/PlayerHotkeys.lua:169 
	At /engine/interface/PlayerHotkeys.lua:161 activateHotkey
	At /mod/class/Game.lua:1866 f
	At /mod/class/Game.lua:1463 fct
	At /engine/interface/PlayerHotkeys.lua:316 
	At /engine/KeyBind.lua:229 

[greycat]

I did a git bisect, and after half a dozen iterations, 4fa09e4294f043fe6164d3bcfbc36930ce847272 is the commit that's causing this problem for me.

Code: Select all

commit 4fa09e4294f043fe6164d3bcfbc36930ce847272
Author: DarkGod <darkgod@net-core.org>
Date:   Tue Oct 22 22:52:52 2013 +0200

    NPCs can use Shoot Down

[darkgod]

Yeah sorry I had the fix yesterday but my internet was down :/
Fixed now