[b39-svn-5045] setupSummon causing summoning error loop

[johnnyzero]

I encountered this bug when fighting summoners in adventuring parties. When a summoner tries to use a summoning talent (like ritch flamespitter), the talent fails, a lua error pops up, and the summoner immediately tries to summon another monster. I'm not sure on the exact number of attempts, but it seems to be a "click close all as fast as you can" sort of scenario. I'm not sure if there is a deeper issue with how the AI handles talent call failures (people in IRC seem to have been getting instagibbed when this sort of bug happens), but in the meantime here's a solution to this particular talent failure.

The lua errors are all nil value errors stemming from this line in setupSummon():

Code: Select all

in game\modules\tome\data\talents\gifts\gifts.lua:
line 129:     m.life_regen = m.life_regen + self:attr("nature_summon_regen")

The nature_summon_regen field looks to be set by some mindstars. The NPCs I've encountered haven't had nature_summon_regen set, so out come the hundreds of nil value lua errors. I'm not sure if player summoners have this field set by default, as I haven't played one. A temporary solution (hack) is to surround this m.life_regen calculation by an if self:attr("nature_summon_regen") then ... end conditional block. A better solution would be to just initialize nature_summon_regen properly.

[edge2054]

Thanks, patch sent to Darkgod.