[b37] Viewing talent list can cause missed action

[78291]

The problem seems to be that bringing up the talent list with 'm' adds messages to the log about using each talent

Code: Select all

[LOG]	78291 uses Luck of the Little Folk.
[LOG]	78291 rushes out!
[LOG]	78291 deactivates Exploit Weakness.
[LOG]	78291 uses Relentless Pursuit.
[LOG]	78291 uses Infusion: Regeneration.
[LOG]	78291 uses Indomitable.
[LOG]	78291 lashes out with a spinning backhand.
[LOG]	78291 uses Perfect Strike.
[LOG]	78291 fails to use Precise Strikes.

though none of that is actually performed. However, failure chances seem to be checked for each talent and if one fails, the player loses that turn. I've seen this happen due to crippling poison, confusion, and equilibrium failures so the actual effect doesn't seem to matter.

[Rectifier]

Confirmed, this happened on my wyrmic on more than one occasion.

[edge2054]

Sorry if I'm talking out of my butt here, I'm a bit out of practice.

But looking at the commit logs for b37 I think this might be related to the unavailable category added to the UseTalent menu.

It looks like it's calling preUseTalent but isn't calling all the parameters it should.

I think line 245 in dialogues/UseTalent should be...

Code: Select all

elseif not self.actor:preUseTalent(t, true, true) then

So it's both silent (to not spam the combat log) and fake (so it never fails and costs the player an action).

e: Tested. Seems to fix it.