[b25] Hidden Treasure message appears again and again

[haenlomal]

Defect Summary:
Hidden Treasure message appears again and again.

Steps to Replicate:
1. Get the Hidden Treasure quest by obtaining all 5 pieces of Trollmire Lore.
2. Observe the pop-up message that appears when the quest is granted.
3. Enter Treasure Stash and kill Bill the Troll (easier said than done!).
4. Go back to Level 3 of the Trollmire.

Expected Results:
No more pop-up messages about the Hidden Treasure appears.

Observed Results:
The message re-appears. In fact, it will re-appear every time the player re-enters Level 3 of the Trollmire.

Comments:
There are actually two separate problems here:

1. The pop-up message reappearing. Ideally, it should only be displayed once.
2. The Hidden Treasure quest is not being set to complete. There is a line of code under data/zones/trollmire/npcs.lua in Bill's on_die hook:

Code: Select all

game.player:resolveSource():grantQuest("trollmire-treasure")

This should probably be:

Code: Select all

game.player:resolveSource():setQuestStatus("trollmire-treasure", engine.Quest.COMPLETED)

On a related note, the text for completing is:

Code: Select all

"You have slain Bill and took his treasure."

However, since technically speaking, one can kill Bill but leave his treasure alone, it is perhaps a bit better to change it to:

Code: Select all

"You have slain Bill. His treasure is yours for the taking."

-- The Haen.

[darkgod]

Fixed, thanks!