[b24] Death msg being displayed *before* related damage msgs

[haenlomal]

Defect Summary:

Death message is displayed before relevant damage messages.


Steps to Replicate:

1. Either land a killing blow on a NPC, or have a NPC land a killing blow on you.


Expected Results:

The damage dealt to the target is displayed, followed by the death message (i.e. "Player killed Wolf!")


Observed Results:

The death message is displayed first, followed by the damage. Among other things, if the player was the victim, it can make it hard to see how much damage was dealt to him/her by the NPC in the final blow.


Comments:

My LUA is not good (more into ISO C and Assembly programming myself), so I may be misintpreting things, by its seems that the function responsible for the displaying the damage messages (displayDelayedLogMessage) is run after the end of every tick. This means that the function currently responsible for displaying the death message, takeHit, will be run before it. Since both functions store source and target information, it may be possible to move the code displaying the death message from takeHit to displayDelayedLogDamage instead.

Then again, this is a minor annoyance at best, so if the work involved is too much, it maybe best to drop it.


Cheers,

-- The Haen.

[Hedrachi]

Not sure if it's related to this, but it sounds like it. Anyhow:

In b21-b24, whenever I save the game without exiting, the log shows "Saving done" before it shows Saving...

The savegame process works, it's just the messages are in reverse order.

[tiger_eye]

Another thing I've noticed is that if you kill something that deals damage to you when hit (such as icy skin or damage shield) with flurry, then you will take damage from all six flurry hits--even if the enemy dies from the first hit.

[Final Master]

Another thing I've noticed is that if you kill something that deals damage to you when hit (such as icy skin or damage shield) with flurry, then you will take damage from all six flurry hits--even if the enemy dies from the first hit.

That's not new, that's old, and intended.

[haenlomal]

Not sure if it's related to this, but it sounds like it. Anyhow:

In b21-b24, whenever I save the game without exiting, the log shows "Saving done" before it shows Saving...

The savegame process works, it's just the messages are in reverse order.

No, this isn't related. The code for handling the saving of the game is totally different from the code segments dealing with game ticks and combat. That said, perhaps a similar bug exists in that section of that code.

-- The Haen.