[b19] the new "swallow" does not seem to work

[marchewka]

lvl 1 dwarven wyrmic, trying to swallow his opponent brought to 8%, resulted in "Rookie tries to swallow unknown!".

Here's the related part of stdout.txt:

[LOG] Rookie tries to swallow unknown!
USING table: 0A7FD3C0 Swallow

[yufra]

Is that all the output that you get? Swallow is now an attack as well, so there should be more. For example, I just created a test character and used swallow and got this:

Code: Select all

[LOG]	Testme tries to swallow Testme!
USING	table: 0x1755ddf0	Swallow
[TALENT WEAPON MULT]	1.3	1	1.5	0	1.2549509756796
[TALENT WEAPON MULT]	1.3	1	1.5	0	1.2549509756796
[TALENT WEAPON MULT]	1.3	1	1.5	0	1.2549509756796
24 frames in 1.003 seconds = 23.9282 FPS (29 keyframes)
[TALENT WEAPON MULT]	1.3	1	1.5	0	1.2549509756796
[ATTACK] attacking with	iron battleaxe
[COMBAT DAMAGE] power(0.869328) totstat(19.200000) talent_mod(1.316228)
[ATTACK] to 	giant crystal rat	 :: 	10.984643321432	1	4	::	1.2549509756796
checkHit	8	3.75
=> chance to hit	65.381486434453
[ATTACK] raw dam	10.984643321432	versus	4	with APR	1
[ATTACK] after range	9
[PHYS CRIT %]	4.5
[ATTACK] after crit	9
[ATTACK] after mult	11.294558781117
[PROJECTOR] starting dam	11.294558781117
[PROJECTOR] after difficulty dam	11.294558781117
[PROJECTOR] res	0	1	 on dam	11.294558781117
[PROJECTOR] after resists dam	11.294558781117
[PROJECTOR] final dam	11.294558781117
[LOG]	Testme hits giant crystal rat for #LIGHT_GREEN#11.29 nature damage#LAST#.
[LOG]	#{bold}#Testme killed giant crystal rat!#{normal}#

We could add this line to the successful swallow if statement:

Code: Select all

			game.logSeen(target, "%s swallows %s whole!", self.name:capitalize(), target.name:capitalize())

[marchewka]

Ok, here's the more expanded stdout.txt part.

[LOG] Rookie tries to swallow unknown!
USING table: 0A7FD3C0 Swallow
26 frames in 1.038 seconds = 25.0482 FPS (32 keyframes)
[TALENT WEAPON MULT] 1.3 1 1.5 0 1.2549509756796
[ATTACK] attacking with steel greatmaul
[COMBAT DAMAGE] power(1.502306) totstat(22.800000) talent_mod(1.316228)
[ATTACK] to forest troll :: 22.542091034451 2 4 :: 1.2549509756796
checkHit 8 -0.35
=> chance to hit 76.363606858811
[ATTACK] raw dam 22.542091034451 versus 4 with APR 2
[ATTACK] after range 29
[PHYS CRIT %] 1
[ATTACK] after crit 29
[ATTACK] after mult 36.39357829471
[PROJECTOR] starting dam 36.39357829471
[PROJECTOR] after difficulty dam 36.39357829471
[PROJECTOR] res 0 1 on dam 36.39357829471
[PROJECTOR] after resists dam 36.39357829471
[PROJECTOR] final dam 36.39357829471
[LOG] Rookie hits forest troll for #LIGHT_GREEN#36.39 nature damage#LAST#.
[LOG] #{bold}#Rookie killed forest troll!#{normal}#
checkHit 15 13.3
=> chance to hit 56.818586174616
[HEALING] 13 Rookie for 9
26 frames in 1.035 seconds = 25.1208 FPS (32 keyframes)
25 frames in 1.006 seconds = 24.8509 FPS (30 keyframes)
[LOG] You pickup 0.90 gold pieces.
[LOG] #YELLOW_GREEN#There is an exit to the worldmap here (press '<', '>' or right click to use).

[yufra]

I grabbed the few lines below from your stdout quote, and these lines show that the swallow did indeed work. You regained health definitely, and probably equilibrium as well. Is the issue that you do not get confirmation that you swallow the target? I agree that confirmation would be nice.

checkHit 15 13.3
=> chance to hit 56.818586174616
[HEALING] 13 Rookie for 9

[marchewka]

Well, you can see in the [LOG] message "Rookie tries to swallow unknown!".
The same message appeared when trying to swallow just any other creature.
Might be just me, but shouldn't it say something more to the lines of "Rookie tries to swallow forest troll"?

[yufra]

Ah, I see what you mean now. The problem is that the "tries to swallow" message is created before you actually have set a target and therefore it doesn't know what you are trying to swallow. Compare this to right-clicking on a target and selecting swallow that way. There has been some discussion of changing the way targeting is handled by talents, but no idea if/when that will be implemented.