Arcane Might does what to crits?

[Snarvid]

The 50% damage I get.

The raw physical power bonus = raw Spellpower I get (convert Spellpower back into raw form, add to physical power, rescale).

The increase physical crit by 25% of bonus spell crit chance I don't get. What does the word "bonus" here mean?

[bpat]

This used to weird me out too. The way I understand it is it does not count general crit chance boosts, like the crit chance you get from Cunning and from Magic of the Eternals. It does count boosts specific to spell crit chance like from Arcane Feed and items.

[jenx]

This used to weird me out too. The way I understand it is it does not count general crit chance boosts, like the crit chance you get from Cunning and from Magic of the Eternals. It does count boosts specific to spell crit chance like from Arcane Feed and items.

I'm not sure this is correct. The formula is simply 0.25 x combat_spellcrit, which is your spellcrit on your character sheet basically, the sum of all spell crits (equipment, talents, cun, etc).

[bpat]

I am almost positive it doesn't take exactly 25% of what's listed on your character sheet. I tested a while back and unless I'm remembering wrong it definitely gave less. Probably worth diving into the code but I don't understand ToME's codebase well enough to fully understand it.

[Erenion]

It's just 25% of your spellcrit.

Code: Select all

if self:knowTalent(Talents.T_ARCANE_MIGHT) then
		addcrit = addcrit + 0.25 * self.combat_spellcrit
end

[jenx]

I am almost positive it doesn't take exactly 25% of what's listed on your character sheet. I tested a while back and unless I'm remembering wrong it definitely gave less. Probably worth diving into the code but I don't understand ToME's codebase well enough to fully understand it.

As I said, here's the code:

Code: Select all

0.25 * self.combat_spellcrit

[Snarvid]

Interesting. So the word "bonus" is essentially meaningless.

My intuition was similar to bpat's, but I thought that a quarter of that number would be relatively small, which seemed odd given how large the physical power bonus is. Thank you for clarifying.