[v1.0.5+] Restart Sustains

A place to post your add ons and ideas for them

Moderator: Moderator

Message
Author
Zizzo
Sher'Tul Godslayer
Posts: 2127
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.5+] Restart Sustains

#16 Post by Zizzo »

Quick release v2a, with some internal rearrangements for compatibility with (a future release of) Improved Auto-explore and Rest. Should be no noticeable change in functionality.
"Blessed are the yeeks, for they shall inherit Arda..."

Zizzo
Sher'Tul Godslayer
Posts: 2127
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.5+] Restart Sustains

#17 Post by Zizzo »

Quickie bugfix release 2a.1, fixing a bug reported elsewhere (I suppose I should be flattered that my addons are being mistaken for core functionality? :) ): the restart-sustains loop in Player:restCheck() wasn't checking whether the player still actually knows the sustain talent or has unlearned it [tricksy player… :wink: ]
"Blessed are the yeeks, for they shall inherit Arda..."

Zizzo
Sher'Tul Godslayer
Posts: 2127
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.5+] Restart Sustains

#18 Post by Zizzo »

Long-time users of this addon will no doubt have noticed that the addon will sometimes spuriously trigger the you-just-lost-a-sustain signal — notably, when your sustains are bounced by the level-up dialog, and on reloading a character after the savefile handling stripped the sustains for export. Well, I just recently discovered that there's a way to detect both of those cases, :) so v2a.2, just pushed out, now filters out both of those false positives. We Apologize for the Convenience.™ :wink:
"Blessed are the yeeks, for they shall inherit Arda..."

Zizzo
Sher'Tul Godslayer
Posts: 2127
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.5+] Restart Sustains

#19 Post by Zizzo »

Further to the preceding, my Mindslayer character found another source of spurious sustain-lost signals: Beyond the Flesh apparently bounces itself whenever you wear or take off any equipment. This one was a little trickier to fix, as it involved surgical alteration of a couple talent cooldowns to add our own don't-signal-for-this flag, but v2a.3, just pushed out, now filters out those false positives. We Apologize for the Convenience.™ :wink:
"Blessed are the yeeks, for they shall inherit Arda..."

Cathbald
Uruivellas
Posts: 743
Joined: Wed Jan 22, 2014 1:46 pm

Re: [v1.0.5+] Restart Sustains

#20 Post by Cathbald »

this has been bugging me for ages and i finally took the time to take the screen and post :
Image
I write guides and make addons too now, apparently

You can go here for a compilation of everything I wrote, plus some other important stuff!

Includes general guides (inscriptions, zone, prodigies), and class guides (Demo, Anorithil, Bulwark, Zerker, Sblade)

Zizzo
Sher'Tul Godslayer
Posts: 2127
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.5+] Restart Sustains

#21 Post by Zizzo »

Cathbald wrote:this has been bugging me for ages and i finally took the time to take the screen and post :
Image
…? I'm getting a 403 Forbidden on the image. Do I need a Discord account to see it?
"Blessed are the yeeks, for they shall inherit Arda..."

HousePet
Perspiring Physicist
Posts: 6203
Joined: Sun Sep 09, 2012 7:43 am

Re: [v1.0.5+] Restart Sustains

#22 Post by HousePet »

I also can't see it and I do have a Discord account.

I think that the server is blocking any access from outside a Discord channel link.
My feedback meter decays into coding. Give me feedback and I make mods.

Cathbald
Uruivellas
Posts: 743
Joined: Wed Jan 22, 2014 1:46 pm

Re: [v1.0.5+] Restart Sustains

#23 Post by Cathbald »

Damn, i can see it though.
On the right click menu, it's written "unark" instead if "unmark" talent for restart.
I write guides and make addons too now, apparently

You can go here for a compilation of everything I wrote, plus some other important stuff!

Includes general guides (inscriptions, zone, prodigies), and class guides (Demo, Anorithil, Bulwark, Zerker, Sblade)

Zizzo
Sher'Tul Godslayer
Posts: 2127
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.5+] Restart Sustains

#24 Post by Zizzo »

Cathbald wrote:On the right click menu, it's written "unark" instead if "unmark" talent for restart.
[sound F/X: source diving] …Ah. Heh. :oops: I prob'ly would never have tripped over that, because I don't normally use the right-click menu except to mark talents for sustain. Easy enough to fix, though; that's pushed out as v2a.4. Thanks.
"Blessed are the yeeks, for they shall inherit Arda..."

Zizzo
Sher'Tul Godslayer
Posts: 2127
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.5+] Restart Sustains

#25 Post by Zizzo »

v3 is a bit of an experiment: we should be able to use 1.6's new callbackOnWait callback (and pre-existing callbackOnRest callback) to implement our sustain restarting without having to ham-handedly overload Player:restCheck() — which, as you probably don't recall, :wink: was the source of some compatibility problems with the Improved Auto-Explore and Rest addon. This approach should (I hope) significantly improve compatibility with other addons that fiddle around with resting.
"Blessed are the yeeks, for they shall inherit Arda..."

Zizzo
Sher'Tul Godslayer
Posts: 2127
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.5+] Restart Sustains

#26 Post by Zizzo »

To my astonishment, some players are still apparently using the old-style Restart Sustains dialog instead of just right-clicking on the talent icon. In particular, a Steam user reports that picking up a talent in the dialog's restart-ordering tree and dragging it onto its own descendant, a case I hadn't considered, predictably turns the tree into a closed reference loop and locks up the game. Truly I have shamed my Computer Science 101 professor… :oops: v3a does the necessary meatball tree surgery to reconstruct the ordering tree in a sensible fashion. We Apologize for the Error.™
"Blessed are the yeeks, for they shall inherit Arda..."

Zizzo
Sher'Tul Godslayer
Posts: 2127
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.5+] Restart Sustains

#27 Post by Zizzo »

And speaking of people still using the Restart Sustains dialog… v3b.1 fixes a bug reported on te4.org: the "Sustains to restart" and "Other sustains" talent lists on the Restart Sustains dialog share a common description area for their selected talents, but they both assumed they had full control over it, so they didn't always notice that they needed to reinstate the description of their selected talent after the user switched focus back from the other list. We Apologize for the Inconvenience.™ :wink:
"Blessed are the yeeks, for they shall inherit Arda..."

Zizzo
Sher'Tul Godslayer
Posts: 2127
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.5+] Restart Sustains

#28 Post by Zizzo »

A Steam user reports that the Void Stars talent is interacting oddly with our sustain-restarting loop, apparently deactivating and reactivating multiple times while resting. Weird interaction, but v3b.2 appears to have it sorted out. We Apologize for the Inconvenience.™ :oops:
"Blessed are the yeeks, for they shall inherit Arda..."

Zizzo
Sher'Tul Godslayer
Posts: 2127
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.5+] Restart Sustains

#29 Post by Zizzo »

Somewhat embarrassingly, this addon doesn't protect from what I've found to be one of the most insidious ways of losing a marked sustain: accidentally hitting the wrong hotkey. :oops: Now, sure, I could just use the existing confirm-use-talent configuration, but (a) I'd have to remember to set that up every time I create a new character or mark a new sustain for restart, and (b) I don't want to have to confirm turning the sustain on, just turning it off.

The solution I settled on, as implemented in v3b.3, is a new game option, "ZOmnibus | Confirm deactivation of marked sustains", which… well, should be self-explanatory. :wink: Our override happens at a low level, and thus should only be applied in circumstances in which the usual confirm-on-use settings would be applicable (so no, you don't get to veto the Weirdling Beast knocking out your marked sustain; that's a different addon :twisted: ).
"Blessed are the yeeks, for they shall inherit Arda..."

Post Reply