[v1.0.4-1.0.5] Enhanced Object Compare

A place to post your add ons and ideas for them

Moderator: Moderator

Message
Author
Zizzo
Sher'Tul Godslayer
Posts: 2009
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.4-1.0.5] Enhanced Object Compare

#31 Post by Zizzo »

Oops, hadn't noticed that Shatter Afflictions runes changed in 1.6.1, which means we have to update our inscription <ctrl>-comparison hook for the rune to match. That's going out as v3g.2.
"Blessed are the yeeks, for they shall inherit Arda..."

Zizzo
Sher'Tul Godslayer
Posts: 2009
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.4-1.0.5] Enhanced Object Compare

#32 Post by Zizzo »

Wait, did Manasurge runes also change in 1.6.1, or was that later in 1.6.4? Either way, that <ctrl>-comparison hook was broken too; that's fixed in v3g.3. We Apologize for the Inconvenience.™
"Blessed are the yeeks, for they shall inherit Arda..."

Zizzo
Sher'Tul Godslayer
Posts: 2009
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.4-1.0.5] Enhanced Object Compare

#33 Post by Zizzo »

Aaand 1.6.5 changes the tooltip text for Shatter Afflictions runes, so we push out v3g.4 to cover that. We Apologize for the Inconvenience.™
"Blessed are the yeeks, for they shall inherit Arda..."

Zizzo
Sher'Tul Godslayer
Posts: 2009
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.4-1.0.5] Enhanced Object Compare

#34 Post by Zizzo »

I recently started experimenting with Annihilators and their mecharachnids (mainly to test this, but still :wink: ), and on examination, it occurs to me that equipment worn by the mecharachnid should be included in the comparison cycle just like with golems and worms that walk. That's now supported in v3h, just pushed out. And since this is developing into kind of a pattern, :wink: I did some internal structural rearranging to make it easy to add more companions — with the convenient side benefit that other addons can now get in on the game. If you're an addon author and your addon provides a persistent companion that lives in, for instance, game.player.addon_buddy, you can add its equipment to the comparison cycle by putting code like the following in your "ToME:load" hook:

Code: Select all

class:bindHook('ToME:load', function(self, data)
  local Object = require 'mod.class.Object'
  if Object.sidekick_fields then
    table.insert(Object.sidekick_fields, 'addon_buddy')
  end
end)
"Blessed are the yeeks, for they shall inherit Arda..."

Zizzo
Sher'Tul Godslayer
Posts: 2009
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.4-1.0.5] Enhanced Object Compare

#35 Post by Zizzo »

More experimenting with mecharachnids reveals another comparison-related wrinkle: the tail-mounted weapon should really be in the comparison candidates list too. This is slightly trickier than it sounds, because technically we're not allowed to wield anything into the mecharachnid tail slot in the normal way; the Tail Attachment talent is apparently pulling some dirty tricks under the hood.

A bit of work, though, and v3h.1 now includes the tail-mounted weapon in the candidate list if it's suitable for the object you're <ctrl>-comparing — steamsaws for the Assault chassis, steamguns for the Armament chassis. Note that steamsaws and steamguns will both still cycle through the player's steamgun and shield and both the mecharachnid's steamguns, since both are wieldable in mainhand and offhand, but that's just a few more taps of <Shift> to get to the tail mount (as always, We Apologize for the Inconvenience™).
"Blessed are the yeeks, for they shall inherit Arda..."

Cathbald
Uruivellas
Posts: 743
Joined: Wed Jan 22, 2014 1:46 pm

Re: [v1.0.4-1.0.5] Enhanced Object Compare

#36 Post by Cathbald »

comparing ethereal rune resulted in this error :
Image
I write guides and make addons too now, apparently

You can go here for a compilation of everything I wrote, plus some other important stuff!

Includes general guides (inscriptions, zone, prodigies), and class guides (Demo, Anorithil, Bulwark, Zerker, Sblade)

Zizzo
Sher'Tul Godslayer
Posts: 2009
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.4-1.0.5] Enhanced Object Compare

#37 Post by Zizzo »

Cathbald wrote:comparing ethereal rune resulted in this error :
[sound F/X: source diving] Ah, just a stupid typo, of the sort I frequently lament that Lua doesn't catch for you at compile-time. (Never ran into it before, because I generally don't use ethereal runes.) Fixed in v3h.2, just pushed out. We Apologize for the Incovenience.™ :oops:
"Blessed are the yeeks, for they shall inherit Arda..."

Cathbald
Uruivellas
Posts: 743
Joined: Wed Jan 22, 2014 1:46 pm

Re: [v1.0.4-1.0.5] Enhanced Object Compare

#38 Post by Cathbald »

anyone : report problem
zizzo, in less than 3hours : what problem ?

cheers ;)
I write guides and make addons too now, apparently

You can go here for a compilation of everything I wrote, plus some other important stuff!

Includes general guides (inscriptions, zone, prodigies), and class guides (Demo, Anorithil, Bulwark, Zerker, Sblade)

HousePet
Perspiring Physicist
Posts: 6166
Joined: Sun Sep 09, 2012 7:43 am

Re: [v1.0.4-1.0.5] Enhanced Object Compare

#39 Post by HousePet »

Zizzo wrote: [sound F/X: source diving] Ah, just a stupid typo, of the sort I frequently lament that Lua doesn't catch for you at compile-time. (Never ran into it before, because I generally don't use ethereal runes.) Fixed in v3h.2, just pushed out. We Apologize for the Incovenience.™ :oops:
It would need a compile time first.
Although I don't really see why this sort of language couldn't have some sort of tool that runs compiler like checks on stuff.
So many easily avoided typos could be avoided. :(
My feedback meter decays into coding. Give me feedback and I make mods.

Zizzo
Sher'Tul Godslayer
Posts: 2009
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.4-1.0.5] Enhanced Object Compare

#40 Post by Zizzo »

Pushing out v3h.3, with a bugfix for acid wave runes. We Apologize for the Inconvenience.™ :oops:
"Blessed are the yeeks, for they shall inherit Arda..."

Cathbald
Uruivellas
Posts: 743
Joined: Wed Jan 22, 2014 1:46 pm

Re: [v1.0.4-1.0.5] Enhanced Object Compare

#41 Post by Cathbald »

i forgot to screen, but also got an issue when comparing acid wave rune after the fix...
I write guides and make addons too now, apparently

You can go here for a compilation of everything I wrote, plus some other important stuff!

Includes general guides (inscriptions, zone, prodigies), and class guides (Demo, Anorithil, Bulwark, Zerker, Sblade)

Zizzo
Sher'Tul Godslayer
Posts: 2009
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.4-1.0.5] Enhanced Object Compare

#42 Post by Zizzo »

Cathbald wrote:i forgot to screen, but also got an issue when comparing acid wave rune after the fix...
If it was recent, it might still be in the error reports folder. Near where save files live, there should be a folder named error-reports/, with subfolders for each game version, and text files in those with the stack traces of errors you've had recently.
"Blessed are the yeeks, for they shall inherit Arda..."

Cathbald
Uruivellas
Posts: 743
Joined: Wed Jan 22, 2014 1:46 pm

Re: [v1.0.4-1.0.5] Enhanced Object Compare

#43 Post by Cathbald »

forgot about that for a while :
Lua Error: /hooks/compare/load.lua:370: attempt to perform arithmetic on field 'apply' (a nil value)
At [C]:-1 __add
At /hooks/compare/load.lua:370 info_cmp
At /mod/addons/compare/superload/mod/class/Object.lua:102 getDesc
At /mod/dialogs/ShowEquipInven.lua:54 on_select
At /mod/dialogs/ShowEquipInven.lua:234 select
At /mod/dialogs/ShowEquipInven.lua:164 super_any_key
At .../addons/compare/superload/mod/dialogs/ShowEquipInven.lua:35 any_key
At /engine/KeyBind.lua:222 receiveKey
At /engine/ui/Dialog.lua:802 keyEvent
At /engine/ui/Dialog.lua:510
Comparing acid runes
I write guides and make addons too now, apparently

You can go here for a compilation of everything I wrote, plus some other important stuff!

Includes general guides (inscriptions, zone, prodigies), and class guides (Demo, Anorithil, Bulwark, Zerker, Sblade)

Zizzo
Sher'Tul Godslayer
Posts: 2009
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.4-1.0.5] Enhanced Object Compare

#44 Post by Zizzo »

Cathbald wrote:forgot about that for a while :
`S cool. :wink:
Cathbald wrote:Comparing acid runes
[sound F/X: source diving] Hmm, what version of the addon do you have? Because that's the same bug Chronosplit was seeing, and I pushed out release 3.8.3 to fix it.
"Blessed are the yeeks, for they shall inherit Arda..."

Cathbald
Uruivellas
Posts: 743
Joined: Wed Jan 22, 2014 1:46 pm

Re: [v1.0.4-1.0.5] Enhanced Object Compare

#45 Post by Cathbald »

indeed, for some reason my game is not updating addons : Image

thanks Zizzo
I write guides and make addons too now, apparently

You can go here for a compilation of everything I wrote, plus some other important stuff!

Includes general guides (inscriptions, zone, prodigies), and class guides (Demo, Anorithil, Bulwark, Zerker, Sblade)

Post Reply