Null Tweaks 2014-12-04: Rocks and Stones

[tilkau]

I just found a bug in this, I think?
I was engaged in a tedious battle with a unique vampire that had Second Life, hit p to bring up the levelup dialog because I noticed I'd leveled up from a minion kill, and got stuck in a loop, printing this:

Code: Select all

Lua Error: ...ddons/nulltweaks/superload/mod/dialogs/LevelupDialog.lua:33: attempt to call method 'hasEffect' (a nil value)
	At [C]:-1 hasEffect
	At ...ddons/nulltweaks/superload/mod/dialogs/LevelupDialog.lua:33 isUnlearnable
	At /mod/dialogs/LevelupDialog.lua:479 color
	At /mod/dialogs/elements/TalentTrees.lua:414 display
	At /engine/ui/Dialog.lua:712 toScreen
	At /engine/Game.lua:163 display
	At /mod/class/Game.lua:1479 

(the graphical display remains blank, aside from the pointer).

I eventually had to kill -9 it (forced termination) and lost that level up (and the whole dungeon level, actually.. Hopefully that lunatic vampire with it.)
I am unsure as to whether the real source of the problem is in NullTweaks, NullPack (Transcendent Fist talents), or NullNewGems (Prismatic Golem talents). Once I reach again L28 I'll test it again (saving first

(current character link)

EDIT: Was not able to reproduce. Annoying.
EDIT2: Was able to reproduce, but don't have a save at a suitable location. More annoying.

[Doctornull]

I just found a bug in this, I think?

Yeah, I encountered something similar. Wrote a fix and then couldn't upload it last night because of the servers all being busy.

Fixed uploaded this morning.

EDIT2: Was able to reproduce, but don't have a save at a suitable location. More annoying.

If you know how to reproduce, could you check the new version? I was never sure how to reproduce.

[tilkau]

I concluded that the previous bug was contingent on not saving before bringing up the levelup dialog. Anyway I haven't encountered it since.

I encountered a new bug instead! : Crash when starting with Custom respec option

I have definitely isolated it to this addon as this error occurs even when this is the only 'non-standard' addon installed.

Steps to reproduce: (not all may be necessary, this is just exactly what I did)
* Use Game options in an existing game to set nulltweaks_respec option to 'Custom"
* start new game
* enter name 'That'
* select Thalore Berserker
* click Play.

Result:

Lua Error: /mod/class/Actor.lua attempt to compare nil with number
At [C]:-1 __lt
At /mod/class/Actor.lua:3954 capLastLearntTalents
At /mod/class/Actor.lua:3981 learnTalent
At /engine/Birther.lua:369 apply
At /mod/dialogs/Birther.lua:292 fct
At /mod/dialogs/Birther.lua:191 checkNew
At /mod/dialogs/Birther.lua:241 atEnd
At /mod/dialogs/Birther.lua:63 fct
At /engine/ui/Button.lua:64 fct
At /engine/Mouse.lua:56 receiveMouse
At /engine/Mouse.lua:94 delegate
At /engine/ui/Dialog.lua:558 mouseEvent
At /engine/ui/Dialog.lua:337 fct
At /engine/Mouse.lua:56

And subsequently the usual blank play area and 'attempt to perform arithmetic on x, a nil value' errors that usually popup when an addon majorly glitches the game.

If greyswandir's 'elemental' or 'weird wyrmic' addons are installed, they will also glitch (changing the crash message) as a side-effect.

[Doctornull]

Steps to reproduce: (not all may be necessary, this is just exactly what I did)
* Use Game options in an existing game to set nulltweaks_respec option to 'Custom"
* start new game
* enter name 'That'
* select Thalore Berserker
* click Play.

I do that, but all it does is correctly start a game with a new Thalore Berserker who has a silly name.

None of the lines in that traceback you posted come from any addon.

I think this could be an issue with another addon, not between Nulltweaks and the core game?

And subsequently the usual blank play area and 'attempt to perform arithmetic on x, a nil value' errors that usually popup when an addon majorly glitches the game.

If greyswandir's 'elemental' or 'weird wyrmic' addons are installed, they will also glitch (changing the crash message) as a side-effect.

With those installed, I do get an error in Weird Wyrmic.

I'll talk to Grayswandir and see if wen can work that one out.

[tilkau]

Steps to reproduce: (not all may be necessary, this is just exactly what I did)
* Use Game options in an existing game to set nulltweaks_respec option to 'Custom"
* start new game
* enter name 'That'
* select Thalore Berserker
* click Play.

I do that, but all it does is correctly start a game with a new Thalore Berserker who has a silly name.

I probably missed a step, quitting and restarting the game after setting the respec option.

It gives you nice battle messages IMO:
"Wolf hits That for 12 physical damage"

None of the lines in that traceback you posted come from any addon.

I think this could be an issue with another addon, not between Nulltweaks and the core game?

Can't be.
As I said:

I have definitely isolated it to this addon as this error occurs even when this is the only 'non-standard' addon installed.

If that was ambiguous: I was talking about having just tome-addon-dev.teaa, tome-items-vault.teaa and tome-stone-wardens.teaa installed, which are the addons that come with tome by default.
Then, installing nulltweaks (and only nulltweaks) triggers the crash,
removing it removes the crash. It's a very discrete and reliable effect on my system.

This is why I was so sure that the bug was related to nulltweaks even though the traceback doesn't point directly to any addon code.

(especially since I don't yet have donator status, so items-vault and stone-wardens addons shouldn't even be doing anything at all if I understand correctly)

With those installed, I do get an error in Weird Wyrmic.

I'll talk to Grayswandir and see if wen can work that one out.

Good to hear you can reproduce that.

[Doctornull]

If that was ambiguous: I was talking about having just tome-addon-dev.teaa, tome-items-vault.teaa and tome-stone-wardens.teaa installed, which are the addons that come with tome by default.
Then, installing nulltweaks (and only nulltweaks) triggers the crash,
removing it removes the crash. It's a very discrete and reliable effect on my system.

This is why I was so sure that the bug was related to nulltweaks even though the traceback doesn't point directly to any addon code.

Yeah, that's what I did.

That's so weird. You're using the newest Nulltweaks, right?

[tilkau]

yeah, tome-nulltweaks_31.teaa . I just checked it again -- provided that respec is set to custom and nulltweaks is installed, crash. Remove nulltweaks or reset respec to standard, game starts as normal.

My configuration looks like:


I'm running ToME4 1.2.4 on Arch Linux, 64bit, FWIW.

EDIT: I also tried resetting all other NullTweaks options above to default, aside from respec. The crash still happens, so I feel reasonably confident I've isolated that option as the sole cause (rather than an interaction between two NullTweaks options)

[Doctornull]

yeah, tome-nulltweaks_31.teaa .

Hmm. Make sure you don't have two versions at once? That could do bad things.

Otherwise, I'm stumped.

[tilkau]

Yeah, I'd already checked that there wasn't another version present, only 31.

The previous error (w/ levelup dialog) seems to have resurrected in a slightly different iteration. I can provide a zip of the save if needed.
The required addons list on this save is somewhat ridonkulously long, but desc.lua can be manually edited to cut it down to

Code: Select all

addons = {'ignore_rc_locks', 'zomnibus', 'nulltweaks', 'uniques', 'items-vault', 'difficulty_addon', 'hz-escorts', 'nullnewgems'}

without apparently changing any functionality, including the nature of the crash:

Code: Select all

Lua Error: ...ddons/nulltweaks/superload/mod/dialogs/LevelupDialog.lua:27: attempt to perform arithmetic on local 'max' (a nil value)
	At [C]:-1 __sub
	At ...ddons/nulltweaks/superload/mod/dialogs/LevelupDialog.lua:27 isUnlearnable
	At /mod/dialogs/LevelupDialog.lua:479 color
	At /mod/dialogs/elements/TalentTrees.lua:414 display
	At /engine/ui/Dialog.lua:712 toScreen
	At /engine/Game.lua:163 display
	At /mod/class/Game.lua:1479 

The save is in the Eidolon plane; I walked up to Eidolon, chose rest, walked up and down until my talent cooldowns wore off, then hit p.

[Doctornull]

Yeah, I'd already checked that there wasn't another version present, only 31.

Hmm. Try something for me?

Open up the game options dialog and change the Respec Generic and Respec Class numbers.

That might fix a bad option installed by a previous version.

[tilkau]

Ha, that's a good thought... woah. Previously, it had stated '100' for each of those parameters (which seemed rather a lot to me, but I wasn't gonna mess with the defaults). Now it says 'nil'. That might be it!

EDIT: Yes, that's it! After editing those fields back to 100, I can now start a game normally with nulltweaks and custom respec! Thanks a lot for your help sorting that out!

EDIT2: That also fixes the resurrected levelup dialog bug too, as far as I can tell

[Doctornull]

Ha, that's a good thought... woah. Previously, it had stated '100' for each of those parameters (which seemed rather a lot to me, but I wasn't gonna mess with the defaults). Now it says 'nil'. That might be it!

EDIT: Yes, that's it! After editing those fields back to 100, I can now start a game normally with nulltweaks and custom respec! Thanks a lot for your help sorting that out!

EDIT2: That also fixes the resurrected levelup dialog bug too, as far as I can tell

Excellent.

I have no idea how they got into that state, but I'm very glad this is resolved. Hope you enjoy the addon now!

[Doctornull]

Minor update: I added a work-around which double-checks the values that were getting nil'd and resets them to sensible defaults.

This should fix the symptoms of the weird interactions that happen between this and some other addons. I still haven't tracked down the core cause, but at least the bugs are no longer visible.

[spiralrazor]

still getting some issues with Wierd wyrmic, trolls, and some of housepets arcane pack.

[Doctornull]

still getting some issues with Wierd wyrmic, trolls, and some of housepets arcane pack.

If you can post the errors, there's a chance I can fix them. If you can't, there's no chance. Thanks!