Geists! [Slowly getting closer to done!]

A place to post your add ons and ideas for them

Moderator: Moderator

Message
Author
NemesisZeru
Archmage
Posts: 335
Joined: Wed Jan 15, 2014 12:56 pm
Location: Somewhere, probably.

Re: Geists! [Repair help desperately needed!]

#46 Post by NemesisZeru »

Zaive wrote:talents = {
T_VILE_AIM = 1,
T_ENVEIL = 1,
T_UNNATURAL_BODY = 1,
T_CALL_SHADOWS = 1,
},

At least it doesn't break when starting up when it's like that.

I tried to fix a few things here and there. Mostly just description fixes. I'll post them up in a bit. Also, for some reason the forum refuses to indent the code even though it is in the edit box. Dunno what to do about that.

Twist the Veil: You need to define range inside the info function. Also remove the second % in %d%, since it'll make it expect another format variable.

Unveil: I posted above what I think it should look like (Completely untested though), but at least in the description the darkness damage %d%% should be changed to %0.2f (%d is whole numbers only, %0.2f goes to 2 decimal places and seems to be the norm for damage display, and %% makes the % sign actually show up in the description instead of being a format flag). The other %d% should be changed to %d, and the confusion power and turns needs to actually be added into the format.

Shadow Alliance:
change:
getCurrentIncrease = function(self, t)
if self:hasEffect(self.EFF_SHADOW_ALLIANCE) then
return self:hasEffect(self.EFF_SHADOW_ALLIANCE).power
else return 0
end
end,
At least changing it to that makes the game not break when trying to view its description, dunno about the actual skill effect.

In Actor.lua:
function _M:breakStealth()
if self:isTalentActive(self.T_ENVEIL) then
local chance = 0
if self:knowTalent(self.T_VEILED_THREAT) then
chance = self:callTalent(self.T_VEILED_THREAT,"getChance") + (self:getLck() - 50) * 0.2
end
-- Do not break stealth
if rng.percent(chance) then return end

self:forceUseTalent(self.T_ENVEIL, {ignore_energy=true})
self.changed = true
end
base_breakStealth(self)
end

The only thing that NEEDS to change to not break the game is base_breakStealth(self) at the end, but I think the other stuff *should* make Veiled Threat do what it's actually supposed to do. Not that I can actually make it work yet...
Oh man, if that was the source of the infinite Enveil loop..

Anyways, I'll get on it tomorrow. I sorta stayed up waaay too late playing some Dark Souls 2, and now I've nearly been awake for 24 hours. Awesome catch, though! If this fixes the infinite Enveil loop, I will be eternally in your debt. :3

HousePet
Perspiring Physicist
Posts: 6215
Joined: Sun Sep 09, 2012 7:43 am

Re: Geists! [Repair help desperately needed!]

#47 Post by HousePet »

If you don't have the no_break_stealth flag on Enveil, cancelling Enveil inside breakStealth() will then call breakStealth() again, and again, and again, and again...
My feedback meter decays into coding. Give me feedback and I make mods.

NemesisZeru
Archmage
Posts: 335
Joined: Wed Jan 15, 2014 12:56 pm
Location: Somewhere, probably.

Re: Geists! [Repair help desperately needed!]

#48 Post by NemesisZeru »

HousePet wrote:If you don't have the no_break_stealth flag on Enveil, cancelling Enveil inside breakStealth() will then call breakStealth() again, and again, and again, and again...
And that does indeed seem to be infinite the problem that stumped the other coders I asked. Now that the problem is known, I can try to fix it, whee. >:3

Edit: Correct, non-sleep deprived version of that sentence

"And that does seem to be the infinite loop problem that stumped the other coders I asked. Now that the problem is known, I can try to fix it, whee. >:3"
Last edited by NemesisZeru on Wed Aug 27, 2014 10:43 pm, edited 1 time in total.

Marson
Uruivellas
Posts: 645
Joined: Thu Jan 16, 2014 4:56 am

Re: Geists! [Repair help desperately needed!]

#49 Post by Marson »

NemesisZeru wrote:And that does indeed seem to be infinite the problem that stumped the other coders I asked.
That comes across to me as throwing those who tried to help under the bus.

NemesisZeru
Archmage
Posts: 335
Joined: Wed Jan 15, 2014 12:56 pm
Location: Somewhere, probably.

Re: Geists! [Repair help desperately needed!]

#50 Post by NemesisZeru »

Marson wrote:
NemesisZeru wrote:And that does indeed seem to be the infinite loop problem that stumped the other coders I asked.
That comes across to me as throwing those who tried to help under the bus.
That was certainly not my intention, and I apologize if it came across that way. I just meant that I had asked other coders to help me figure it out, and they weren't sure what could be causing my special brand of failure. Now that a possible cause is found, I can try to fix it(Which isn't meant as a slight against other coders or anything, either. It just looks simple enough that I think I might actually be able to fix it myself. The tricky part was just finding it in the first place!).

Hell, looking back, I didn't even type the sentence correctly! " be infinite the problem"? I don't even know what that means, haha. Not to make excuses, but I had mentioned in the post before that I had been up for nearly 24 hours at that point, and my brain was clearly too tired to even form coherent sentences.

Anyways, I didn't mean to throw anyone under any sort of bus, and I'm really sorry if it came across that way. I really, really appreciate all the help I've gotten with this project, and I'd never say anything bad against the people who have helped this get as far as it has

Edit: I've edited my previous post to actually have proper, y'know, grammar, and not that "be infinite the problem" stuff. Previous typo was left in above it, just to be safe.

NemesisZeru
Archmage
Posts: 335
Joined: Wed Jan 15, 2014 12:56 pm
Location: Somewhere, probably.

Re: Geists! [Repair help desperately needed!]

#51 Post by NemesisZeru »

Anyways, working on what hopefully will be some fixes, I'm just a bit under the weather currently.

NemesisZeru
Archmage
Posts: 335
Joined: Wed Jan 15, 2014 12:56 pm
Location: Somewhere, probably.

Re: Geists! [Repair help desperately needed!]

#52 Post by NemesisZeru »

Progress! I had one too many 'end's in the vile-tactics.lua, lol. Stealth is probably still broken(Still need to work on that), but hey, I made it to the character creation! So, here's a tiny sneak peek. :3

Image

NemesisZeru
Archmage
Posts: 335
Joined: Wed Jan 15, 2014 12:56 pm
Location: Somewhere, probably.

Re: Geists! [Repair help desperately needed!]

#53 Post by NemesisZeru »

Alright, now that I can get in-game, the fun begins!

Shadowsense's icon won't show.
Image

Unveil luas if moused over, and is also 5/5 from the start.
((FIXED! No clue if it works, but you can mouse over it now!))

Vile Aim causes a lua error on use. I think it still did damage, though!
Image

And Enveil, surprise surprise, lua'd as well: (Still need to mess with Dark Veil as a whole, so mostly marking this for posterity, as it seems to be a more detailed version of Vile Aim's error)
Image


Still, now that the syntax errors seem to be out of the way, definite progress is being made. Thanks, everyone! x3

If anyone wants to take a look at these problems and try to figure them out, a new 7z is included at the bottom of this post.
Attachments
tome-phantom.7z
(28.73 KiB) Downloaded 173 times

Zaive
Archmage
Posts: 313
Joined: Mon May 24, 2010 1:33 pm

Re: Geists! [Slowly getting closer to done!]

#54 Post by Zaive »

I've had some weird issues where if the description was bugged out, it would throw out an error AND put a point in the skill when moused over. So fixing the description should fix random points being in the skill as well.

I'm not getting your enveil or vile aim errors. It looks like its due to "self" not getting passed through base_breakstealth. Since the downloadable does have base_breakstealth(self) in the code those errors aren't happening to me.

I still got the Enveil infinite loop due to a typo. It's no_break_stealth. Is the version you're working with the same thing as the download you posted? :?

The description for Shadow Alliance has %d%. Should be %d, since the second % symbol is making it expect another formatting variable.
Same thing on twist the veil. Also, range needs to be defined inside the info function.

Shadowsense's image has a bit depth of 8. Every single other image has a bit depth of 24. I don't know if that is what causes the problem or not, but...
I fixed Shadowsense's image! I made a blank paint image and then pasted shadowsense's image on to it. Yup.

Shadow net's description claims it slows for 1% turns?
Attachments
SHADOWSENSE.png
SHADOWSENSE.png (2.24 KiB) Viewed 5239 times
Last edited by Zaive on Fri Sep 12, 2014 7:17 pm, edited 1 time in total.
Burb Lulls wrote:"FLURRYFLURRYFLURRYFLURRYFLURRYFLURRY"

NemesisZeru
Archmage
Posts: 335
Joined: Wed Jan 15, 2014 12:56 pm
Location: Somewhere, probably.

Re: Geists! [Slowly getting closer to done!]

#55 Post by NemesisZeru »

Zaive wrote:I've had some weird issues where if the description was bugged out, it would throw out an error AND put a point in the skill when moused over. So fixing the description should fix random points being in the skill as well.

Yeah, Unveil is fixed. :D

I'm not getting your enveil or vile aim errors. It looks like its due to "self" not getting passed through base_breakstealth. Since the downloadable does have base_breakstealth(self) in the code those errors aren't happening to me.

Yeah, I just tried again and didn't get an error, oddly enough(at least for Vile Aim). Weirdness.

I still got the Enveil infinite loop due to a typo. It's no_break_stealth. Is the version you're working with the same thing as the download you posted? :?

Yeah, I believe so. I'll make another 7z just in case.

The description for Shadow Alliance has %d%. Should be %d, since the second % symbol is making it expect another formatting variable.
Same thing on twist the veil. Also, range needs to be defined inside the info function.

I tried that(then later moving it to just 2, since it's a static number), but it just keeps luaing. I'll enclose the latest error at the bottom. As for the Shadow Alliance change, done!

Shadowsense's image has a bit depth of 8. Every single other image has a bit depth of 24. I don't know if that is what causes the problem or not, but...
I fixed Shadowsense's image! I made a duplicate of one of the other images and then copy/pasted shadowsense's image on top of it. I don't know WHY this worked but it worked. Also the bit depth of it is 32.
Oh? Interesting. I tried that, but had no luck. I actually ended up making a new icon, hehe. Not that fancy, but eh. The bit depth thing is interesting, though. I had it set to auto-detect on that. Weirdness abound, eh?

Image
Attachments
SHADOWSENSE.png
SHADOWSENSE.png (3.71 KiB) Viewed 5239 times

NemesisZeru
Archmage
Posts: 335
Joined: Wed Jan 15, 2014 12:56 pm
Location: Somewhere, probably.

Re: Geists! [Slowly getting closer to done!]

#56 Post by NemesisZeru »

And here's -absolutely- the most recent 7z, made just a few seconds ago. I don't think I can put two files in one post, though. Sorry!
Attachments
tome-phantom.7z
(29.46 KiB) Downloaded 186 times

Zaive
Archmage
Posts: 313
Joined: Mon May 24, 2010 1:33 pm

Re: Geists! [Slowly getting closer to done!]

#57 Post by Zaive »

The problem with twist the veil's description now is that the number of formatting queues in the description (None) doesn't match the number of variables in the format (1). Since there's no % symbols calling for format variables in the description the :format section can be removed entirely.
Burb Lulls wrote:"FLURRYFLURRYFLURRYFLURRYFLURRYFLURRY"

NemesisZeru
Archmage
Posts: 335
Joined: Wed Jan 15, 2014 12:56 pm
Location: Somewhere, probably.

Re: Geists! [Slowly getting closer to done!]

#58 Post by NemesisZeru »

Zaive wrote:The problem with twist the veil's description now is that the number of formatting queues in the description (None) doesn't match the number of variables in the format (1). Since there's no % symbols calling for format variables in the description the :format section can be removed entirely.
Oooh...I see. Alright, I'll do that. :3

Asked on the irc, and people seem to prefer the old icon, so I'll see if your fix works. Thanks for the help there! I had no idea why one icon failed and the others didn't. x3

As for Shadow Net...not sure. I'll mess around with it.

Currently messing around with Shadow Alliance(made the wording less obtuse). I notice the buff icon it showed while active(IE, in range of a Shadow) doesn't work anymore(At least, I'm pretty sure it used to have an icon), and thus you can't really see how much stealth power you're getting. Anyone know how to fix this?
Last edited by NemesisZeru on Fri Sep 12, 2014 8:04 pm, edited 1 time in total.

Zaive
Archmage
Posts: 313
Joined: Mon May 24, 2010 1:33 pm

Re: Geists! [Slowly getting closer to done!]

#59 Post by Zaive »

Strange. Shadow Alliance is working just fine for me.
Enveil still has no_stealth_break = true, which does absolutely nothing, instead of no_break_stealth = true. FIX IT ALREADY :<

Tinkering with Unveil a bit:
204: self.project -> self:project
185: game.level.MAP -> game.level.map
Last edited by Zaive on Fri Sep 12, 2014 8:08 pm, edited 2 times in total.
Burb Lulls wrote:"FLURRYFLURRYFLURRYFLURRYFLURRYFLURRY"

NemesisZeru
Archmage
Posts: 335
Joined: Wed Jan 15, 2014 12:56 pm
Location: Somewhere, probably.

Re: Geists! [Slowly getting closer to done!]

#60 Post by NemesisZeru »

Zaive wrote:Strange. Shadow Alliance is working just fine for me.
It is? I DID change the wording, admittedly, but I didn't think that'd disable the icon that shows up when in range and stuff.

Current description on my end is:

"Your stealth power is increased by %d for every one of your shadows within radius %d of you." Could changing the wording have somehow broken the buff icon? If so, could you pastebin me the working version of Shadow Alliance you have?

Zaive wrote:Strange. Shadow Alliance is working just fine for me.
Enveil still has no_stealth_break = true, which does absolutely nothing, instead of no_break_stealth = true. FIX IT ALREADY :<

Done, done. I keep forgetting. x3

Tinkering with Unveil a bit:
204: self.project -> self:project
185: game.level.MAP -> game.level.map
Alright, made the Unveil changes.

Post Reply