[v1.7.0+] Talents in Tooltips

[Zizzo]

As you may or may not recall, one of the features added by my Tinker Tinkering addon is to modify the tooltip of tinkers that grant talents to include a description of the talent they grant. It occurs to me that that sort of modification could be useful more generally, since there are lots of objects that confer talents when worn or carried. Thus my new Talents in Tooltips addon.

This addon adds the game option "UI | Conferred talent description in tooltips", which does basically what I describe above. The default setting is Never, which keeps current game behavior; the other options are Single, which only adds a talent description if the object confers only one talent, and Always, which will add descriptions for all granted talents, even if there are several (which I can imagine could potentially get unwieldy, hence the Single option just in case).

[Looking ahead, I could maybe see this going into a future release of ZOmnibus, depending on how people feel about it.]

[Zizzo]

Couple fixes and new features in v1a:

• We now support talents conferred by demon seeds. Similar support for tinkers is included in Tinker Tinkering, so we don't duplicate that here.
• Demon seeds (and probably tinkers) can leave behind zero-level "stub" talents when you detach them; we should skip those.
• Similarly, it seems silly to add the Block talent description to every shield.

[Zizzo]

I suppose it should have occurred to me that Command Staff on staffs should probably be ignored the same as Block on shields. That's going out as v1a.1.

[Zizzo]

Right, and also ignore the Attune Mindstar talent on mindstars. That's going out as v1a.2. We Apologize for the Inconvenience.™

[Zizzo]

Couple bugfixes in v1a.3:

• Wasn't properly noticing and reporting on-hit and on-crit talents.
• Dig on pickaxes is yet another talent we should be skipping.

[Zizzo]

Further refinements: some objects both activate for a talent and trigger it on-hit at the same level, and since the activation description is already describing the talent, we don't need to add it again. That's covered in v1a.4.

[Zizzo]

• We now support talents conferred by demon seeds. Similar support for tinkers is included in Tinker Tinkering, so we don't duplicate that here.

You'd think I'd know better than to say things like that… We do add the talent description to the tinker's description in the Create Tinker dialog, but not to the tooltip for tinker objects themselves. That's added in v1a.5. We Apologize for the Omission.™

[Zizzo]

Well, this one's a doozy… For multiple characters so far, I've seen the game start breaking and behaving weirdly shortly after I found EoR's Medical Urgency Vest, and by pure serendipity, I managed to track it down to this addon. I guess no one else is using it?

So here's the scoop: Medical Urgency Vest confers a talent named (appropriately enough) Medical Urgency Vest when worn, which handles the pseudo medical injector provided by the armor. Naturally, we try to describe that conferred talent in the object's tooltip (that's our job, after all) — but this talent's .info() method really isn't expecting to be called before you've worn the armor and it's done its setup stuff. It doesn't completely blow up everything, since we wrapped it in a pcall(), but it does enough damage that the talent is left stuck on the player in a partly inconsistent state, whence it can randomly pop up and break stuff (notably, occasionally causing "stuck" temporary effects).

Anyway, practical upshot, v1b fixes this by temporarily installing the necessary inscriptions_data{} from the object just long enough for the talent description to have access to it. This also affects Life Support, I think, since it has a similar talent, but I've never created it, so I can't attest to it.