[v1.0.0-1.0.5] Ignore Race/Class Locks

A place to post your add ons and ideas for them

Moderator: Moderator

Message
Author
Ritz
Cornac
Posts: 41
Joined: Sun Jan 27, 2013 4:31 pm

Re: [v1.0.0-1.0.5] Ignore Race/Class Locks

#31 Post by Ritz »

Mex wrote:I can't believe this addon is even allowed - it's basically cheating...
With that kind of logic, the vast majority of add-ons should be banned this very moment.

ster
Spiderkin
Posts: 492
Joined: Tue Dec 13, 2016 7:05 pm

Re: [v1.0.0-1.0.5] Ignore Race/Class Locks

#32 Post by ster »

Ritz wrote:
Mex wrote:I can't believe this addon is even allowed - it's basically cheating...
With that kind of logic, the vast majority of add-ons should be banned this very moment.
Mex contracted irony poisoning recently and the memes from the tome discord are leaking out
<Shibari> You're full of shit
<darkgod #tome> ster is a troll
<Sheila> and ster, i do agree with you on most things game-related, but do try to not be such an ass!
<mex> your posts lead to people like me being abused and murdered

Ritz
Cornac
Posts: 41
Joined: Sun Jan 27, 2013 4:31 pm

Re: [v1.0.0-1.0.5] Ignore Race/Class Locks

#33 Post by Ritz »

ster wrote:
Ritz wrote:
Mex wrote:I can't believe this addon is even allowed - it's basically cheating...
With that kind of logic, the vast majority of add-ons should be banned this very moment.
Mex contracted irony poisoning recently and the memes from the tome discord are leaking out
Ah, darn, I took the bait. Thanks, I'll show myself out.

Zizzo
Sher'Tul Godslayer
Posts: 2032
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.0-1.0.5] Ignore Race/Class Locks

#34 Post by Zizzo »

So my Krog character just received what I'm assuming is the Krog-unlock quest. Having so far unlocked Mindslayers with a Mindslayer, Stone Wardens with a Stone Warden and Demonologists with a Demonologist, I'm looking forward to unlocking Krogs with a Krog — and it occurred to me that maybe we ought to have an achievement for unlocking a race or class with a character of that race/class. I'm working on that now and will release it when I can confirm that it works; in the meantime I'm soliciting names for the achievement. For now I'm calling it "Purely a Formality", but I'm sure our assembled commentariat can better me on that. :wink:
"Blessed are the yeeks, for they shall inherit Arda..."

astralInferno
Uruivellas
Posts: 763
Joined: Mon Jan 27, 2014 10:40 am

Re: [v1.0.0-1.0.5] Ignore Race/Class Locks

#35 Post by astralInferno »

That's a pretty good name as is! Maybe something to do with chronomancy/paradox?
"Zemekkys is Scowling" ?

Zizzo
Sher'Tul Godslayer
Posts: 2032
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.0-1.0.5] Ignore Race/Class Locks

#36 Post by Zizzo »

astralInferno wrote:That's a pretty good name as is!
Yeah, it kinda grew on me after a while, so I decided to go with it (thanks for the suggestion, tho'). And with my newly-"legal" Krog to attest that it works, I'm pushing it out as v1a.
"Blessed are the yeeks, for they shall inherit Arda..."

Axiom
Posts: 2
Joined: Sat Jun 30, 2018 10:56 pm

Re: [v1.0.0-1.0.5] Ignore Race/Class Locks

#37 Post by Axiom »

This addon doesn't unlock the Demented classes when playing Embers of Rage.

Zizzo
Sher'Tul Godslayer
Posts: 2032
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.0-1.0.5] Ignore Race/Class Locks

#38 Post by Zizzo »

Aaand I got caught out being lazy in doing the lock checks for our new achievement. :oops: v1a.1 should (I hope) fix it. We Apologize for the Inconvenience.™
"Blessed are the yeeks, for they shall inherit Arda..."

Zizzo
Sher'Tul Godslayer
Posts: 2032
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.0-1.0.5] Ignore Race/Class Locks

#39 Post by Zizzo »

Well, that didn't work. :x :roll: :oops: v1b at least seems to not throw stack traces anymore; We Apologize for the Error.™ This release also fixes a request from the Steam page, making Demented classes available from Embers of Rage.
"Blessed are the yeeks, for they shall inherit Arda..."

Zizzo
Sher'Tul Godslayer
Posts: 2032
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.0-1.0.5] Ignore Race/Class Locks

#40 Post by Zizzo »

Embers 1.1.0 adds a new tinker class Annihilator and a new evolution Technomancer. The former uses the standard locking mechanism, so we get it for free, but the latter uses a new mechanism that would have been tricky to bypass — except that our benevolent overlord saw me coming and gave me a convenient hook to hang the necessary changes on. :mrgreen: :wink: That's going out as v1c.
"Blessed are the yeeks, for they shall inherit Arda..."

Zizzo
Sher'Tul Godslayer
Posts: 2032
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.0-1.0.5] Ignore Race/Class Locks

#41 Post by Zizzo »

As reported to me from the te4.org addons section, the currently available version of Simplified Prodiy Requirements is somewhat outdated, and basically clobbers the High Thaumaturgist and Fallen evolutions — which is tripping us up in this addon, which unilaterally assumes they're present. Easy enough to check for, though; that's pushed out as v1d.1.
"Blessed are the yeeks, for they shall inherit Arda..."

Zizzo
Sher'Tul Godslayer
Posts: 2032
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.0-1.0.5] Ignore Race/Class Locks

#42 Post by Zizzo »

v1d.2 is… well, I guess you'd call it a compatibility release, in that it fixes something that could lead to incompatibility with other addons. See, the Purely a Formality achievement checks whether your current race/class is unlocked, which (surprisingly) requires a full-blown Birther dialog under the hood, and while we're manipulating said dialog, it's trying to set its display tile for the character — which may not work for addon races or classes that weren't expecting to need descriptors. Fortunately, the tile-setting part of the dialog can easily be removed while we're working (one of the advantages of working in Lua :wink: ).

[EDIT: [sound F/X: forehead repeatedly striking desk] Okay, that was never gonna work. Trying again with v1d.3. We Apologize for the Error.™]
"Blessed are the yeeks, for they shall inherit Arda..."

yutio888
Cornac
Posts: 44
Joined: Thu Dec 26, 2013 1:54 pm

Re: [v1.0.0-1.0.5] Ignore Race/Class Locks

#43 Post by yutio888 »

Using this addon might slow the game. Birther.new is called inside setAllowedBuild, and this is a very costly operation. Unluckily, some unlocks are very easy to trigger, e.g., Summon talent used by monster will try unlock Summoner, and will freeze the game for about half second in my laptop, and make a noticeable lag.

Zizzo
Sher'Tul Godslayer
Posts: 2032
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.0-1.0.5] Ignore Race/Class Locks

#44 Post by Zizzo »

yutio888 wrote: Sun Jun 20, 2021 1:53 am Using this addon might slow the game. Birther.new is called inside setAllowedBuild, and this is a very costly operation. Unluckily, some unlocks are very easy to trigger, e.g., Summon talent used by monster will try unlock Summoner, and will freeze the game for about half second in my laptop, and make a noticeable lag.
Yes, I've run into that, and I'm not sure how much can be done about it. Some of the race/class descriptors' locked() methods actually do require a full-blown Birther dialog; I've run into bugs trying to skip that.

[Hmm, now that you mention it, I wonder how much of a Birther dialog we actually need for this purpose. Maybe I could fake something up… Let me experiment with that for a bit.]
"Blessed are the yeeks, for they shall inherit Arda..."

Zizzo
Sher'Tul Godslayer
Posts: 2032
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.0-1.0.5] Ignore Race/Class Locks

#45 Post by Zizzo »

Now that I've confirmed that the achievement still works by diverting one of my Drem characters to go do the Drem unlock :mrgreen: (after having been accidentally spoiled on where that is :oops: ), I'll push out v1e, which in my testing so far does seem to be faster about checking for the achievement. We manage this by creating a new FakeBirther object to pass to the various race/class lock checks, copying just enough of the Birther dialog's functionality to satisfy their needs. [At least I hope we are; specifically, we copy methods :isDescriptorSet(), :setDescriptor(), :isDonator() and :updateDescriptors(). If any race/class addons are using more than that in their lock checks, do please let me know. :oops: ]
"Blessed are the yeeks, for they shall inherit Arda..."

Post Reply