[v1.7.0+] Bikini Tinker

[Zizzo]

As I read the code, the only reason attaching a tinker to a bikini counts as taking it off for purposes of the associated achievement is that attaching a tinker to an equipped item is implemented internally by pretending to take off and re-equip the item in order to recompute its worn effects. This strikes me as an implementation detail rather than an intrinsic characteristic of how tinkers are meant to be seen as working in-game. (T2, for instance, handles equipment changes by simply recomputing all equipment bonuses from scratch, and tinkers, if it had them, would presumably be handled the same way.)

To address this, then, I've put together a new Bikini Tinker addon, which basically puts a tiny wrapper around the internal attach-tinker and detach-tinker methods that restores the internal not-taken-off flags that get inadvertently clobbered for bikinis and mankinis. This should work equally well for tinkers from Embers of Rage and demon seeds from Ashes of Urh'Rok, and should also work for the chainmail bikinis/mankinis I recently added to Bikini Colors. And if I've done this right, it shouldn't affect actually taking off the bikini, so no sneaking around the achievement requirements that way.

[Now, depending on your perspective, this addon is either a blatant cheat, and thus obviously not suitable for inclusion in ZOmnibus, or a bugfix addon, and thus subject to my usual concern that I'd have to claw it back out of ZOmnibus if the bug is ever fixed.]

[Implementation notes:

Code: Select all

Superload:
  mod.class.Actor:
    doTakeoffTinker() [to protect bikinis/mankinis]
    doWearTinker() [to protect bikinis/mankinis]