Necrofriends: Necromancy Addon Compatitibility Patch

[astralInferno]

Hallo!

This addon requires and combines the changes from the Eternal Darkness, Necromancy+ and Deathknight addons. Unabashedly, I made it for personal use and some of my choices were selfishly designed to help me.

Bear in mind that this will almost definitely make Necromancers OP.

Get the addon here! Remember, it requires the Eternal Darkness, Necromancy+ and Deathknight addons installed and active.

Necromancers end up with:

Necrotic Minions
Create Minions
Undeath Link
Surge of Undeath
Dark Empathy - gives bonuses. As in Eternal Darkness, minions don't hurt you or each other.

Nightfall
Completely unchanged, but has a fifth talent: Necromancy+'s Nether Breach.

Grave
New talents, as in Eternal Darkness, but...

Chill
New category featuring the /old/ grave talents. Fourth talent is Necromancy+'s Ghost Touch.

Animus
Animus Hoarder has a chance to refund souls on minion death, as in ED.

Vampirism
ED Tree.

Charnel
Necromancy+ tree, Vampiric Gift is fourth talent.

Spell/Ice
I like having it as an option. Sue me.

Advanced Necrotic Minions
1-Undead Explosion
2-Soulwinds (Necromancy+, lacks the soul refund as that's on animus hoarder. (And I was exhausted of code diving))
3-Assemble
3-Shadow Tunnel (Including Curse of the Meek as in Necromancy+)
4-Minion Mastery

Shades
The new talents from ED are in here. Only Forgery of Haze remains. Note that Shadow Tunnel and Frostdusk are in other trees, and Shadow Tunnel includes Meek.

Dread
...this'll be the thing I did just for me. I love Dread so much. From Deathknight.

Corpse, Reaper
New ED trees.

Necrosis
Now generic. Aura Mastery will stack with Dread. Lichfrom grants star fury /and/ finger of death because /why not/.

Dead Secrets
As in Necromancy+.

I'll be honest; a lot of this hasn't been tested much or at all. When I make my own stuff I try to do a baseline test for everything, but there's just /so much/ in here. I assume that all the unique trees and talents will work fine. I'm worried Dead Secrets won't work. If you find anything that isn't working, please tell me.

Both Housepet and Razakai helped me with a couple of things making this, and of course the majority of the work remains theirs.

Enjoy!

[lordofultima]

can you maybe include the versions of necro+,eternal darkness and deathknight you're using? as I have all 3 mods active as well as necrofriends however it just freezes at 100% when trying to load up the character creator

[astralInferno]

idk what to tell you. I'm using the most recent versions of all of those addons.

I know cause someone asked me about the same problem on steam, and I spent a while trying to work out what was wrong. I failed. It works fine for me, even when downloaded off the site, and I can't find an error. In case they're different, can you go into the TalesMajEyal folder and give me the te4_log next time it breaks?

[astralInferno]

christmas brainwave: have you got the 'alter necromancy talents' setting in Necromancy+ turned off? That would probably cause this issue.

Edit: This was the issue for the person in steam comments.

[Nim]

I'm... surprisingly okay with this idea. Probably not going to use it personally, mind, but to be honest, Lichform has needed a bit of a buff. How about making it so that Finger of Death kicks in when Lichform reaches level 7?

[astralInferno]

I could do, but I quite like it as a baseline bonus. As it stands in generic tome, you get lichform working and what it gives you is the POTENTIAL to have new talents. With finger of death you have a guaranteed new spell on the spot that you can use.

...plus, level six lichform is already a slew of bonuses.

Glad you like the idea.

[Hellcommander]

found an error related to necrofriends (might be because i have necromancy+ option alter talents on)
/engine/interface/ActorTalents.lua:150: in function </engine/interface/ActorTalents.lua:140>
Lua Error: /engine/interface/GameTargeting.lua:119: /engine/interface/ActorTalents.lua:150: /data-necrofriends/talents/spells/necroticminions.lua:839: attempt to perform arithmetic on field 'combat_spellcrit' (a table value)
stack traceback:
/data-necrofriends/talents/spells/necroticminions.lua:839: in function 'applyDarkEmpathy2'
/data-necrofriends/talents/spells/necroticminions.lua:762: in function 'necroSetupSummonHacked'
/data-necrofriends/talents/spells/necroticminions.lua:938: in function </data-necrofriends/talents/spells/necroticminions.lua:916>
[C]: in function 'xpcall'
/engine/interface/ActorTalents.lua:147: in function </engine/interface/ActorTalents.lua:140>
At [C]:-1
At [C]:-1 error
At /engine/interface/GameTargeting.lua:119 fct
At /engine/interface/GameTargeting.lua:125 targetMode
At /engine/interface/GameTargeting.lua:254 targetMouse
At /mod/class/Game.lua:2159 fct
At /engine/Mouse.lua:58

[Hellcommander]

seems the error only shows if you get a spellcrit on create minion

[astralInferno]

That's useful. I'll see about fixing it as soon as I can, but will probably need to consult with people.

[Hellcommander]

nm i ended up forgetting to turn on eternal darkness

on about message of error i deleted

[astralInferno]

Ah. Yeah, that'd do it.