Particle crashes

Moderator: Moderator

Post Reply
Message
Author
aardvark
Wyrmic
Posts: 200
Joined: Wed Aug 22, 2012 12:16 am

Particle crashes

#1 Post by aardvark »

I note that the recent r5662 update hopefully fixes the particle related crashes by introducing extra checks before the lua_pcalls in the particles.c file. I don't think that's going to fix them, though, since those were already protected calls. My (relatively unfamiliar) reading of the code says that after those errors are logged a default particle cloud(?) is generated. I think the problem is on line 285 of particles-gas.c, which goes (lines 284-286 of b42):

Code: Select all

	lua_rawgeti(L, LUA_REGISTRYINDEX, gz->generator_ref);
	lua_call(L, 0, 1);
	if (!lua_isnil(L, -1))
It's that unprotected lua_call that I think is biting players. Maybe?

darkgod
Master of Eyal
Posts: 10750
Joined: Wed Jul 24, 2002 9:26 pm
Location: Angolwen
Contact:

Re: Particle crashes

#2 Post by darkgod »

particle_gas is never used :)

And yes my fix seem to actually work, game ran for many hours under very high particle load (never ending urkis fight with auto turn passing).
[tome] joylove: You can't just release an expansion like one would release a Kraken XD
--
[tome] phantomfrettchen: your ability not to tease anyone is simply stunning ;)

Post Reply