Particle updater error

[yufra]

So I noticed a lot of stdout of the following type:

Code: Select all

L(1e59000) Particle updater error 1b076600 (3, 3): attempt to call a table value

It seems like these errors are never cleared since I saved/loaded the game and I was still getting this every display call. Is there a reason we shouldn't do something like the following?

Code: Select all

diff --git a/src/particles.c b/src/particles.c
index ceac9d6..b8f9998 100644
--- a/src/particles.c
+++ b/src/particles.c
@@ -543,6 +543,7 @@ void thread_particle_run(particle_thread *pt, plist *l)
        if (lua_pcall(L, 1, 0, 0))
        {
                printf("L(%x) Particle updater error %x (%d, %d): %s\n", (int)L, (int)l, l->updator_ref, l->emit_ref, lua_tostring(L, -1));
+               ps->i_want_to_die = TRUE;
                lua_pop(L, 1);
        }

[darkgod]

Yeah probably, but I'd like to find the underlying issue :/