Sustained combat arts- show active ones when using m-menu

[Chattius]

I normally select sustained combat arts by pressing m and then moving through the list. It would be nice if the list would mark stuff which is already sustained.
I use the hotkeys 1-10 for my active combat arts, being a shadow blade there are a lot. So in difference to a fighter type the shadow blade has no room for sustained ca's on the hotkey list (which are also a lot)

Probably i do something wrong, but i am old and getting lazy in remembering what key was connected to which spell.

Something else while playing shadow blades/rogues:
These d*** rings of invisibility make the invisibility spell somehow not needed. Stealth (hide in plain sight, not detected after a backstab) is too far away from 100% compared to a ring of invisibility.
Many artefacts are light sources which bites with stealth/invisibility.

[greycat]

I agree that it would be nice to mark current effects somewhere other than in the hotkey list. Either on the m screen, or in the corner of the main map, or something.

That said, it's not obvious, but you can actually have more than 12 hotkeys. There seem to be 36 total, in groups of 12. PageUp and PageDown will flip among the groups. On my system, Ctrl 1 starts out the second group, and Shift 1 starts out the third group. I don't know how universal these key bindings are, especially when the Right Paren in the default first group doesn't work until I rebind it manually....

So anyway, you might consider moving all your sustained stuff to the second or third group, then flipping to it to check on them periodically. As a workaround.

[shani]

It's could be realy helpful if you could see active sustained talents are in the 'm' screen.

[yufra]

I agree, the actively sustained talents should be shown both in the m-menu and in the hotkeys area. I am starting to use T-Engine to write my own RL, and what better way to familiarize myself with the codebase than to dive into it.

It wasn't until looking in the code that I realized the HotkeysDisplay already does this, showing active tasks in yellow. I am red/green color-blind so I never noticed this (the variation between yellow and green are too subtle for such small text). I changed the active color to blue in the patch below and can see it much better. DG, can you revisit the color choices?

Code: Select all

--- HotkeysDisplay.lua.old	2010-07-13 08:49:29.000000000 -0700
+++ HotkeysDisplay.lua	2010-07-13 08:49:35.000000000 -0700
@@ -78,7 +78,7 @@
 				color = {255,0,0}
 			elseif a:isTalentActive(t.id) then
 				txt = t.name
-				color = {255,255,0}
+				color = {0,0,255}
 			else
 				txt = t.name
 				color = {0,255,0}

I had originally planned on having the color scheme of the m-menu reflect that of the hotkeys, but digging through the code I found that would require changes to the engine.Dialog.drawSelectionList function and decided that this fix was much cleaner. Here is the unified diff that adds "active" to the parentheses in the m-menu if a talent is active. Let me know if you think these patches are sufficient, and if you would prefer the color scheme implemented I can take a look into doing that. Cheers!

Code: Select all

--- UseTalents.lua.old	2010-07-13 09:09:50.000000000 -0700
+++ UseTalents.lua	2010-07-13 13:21:36.000000000 -0700
@@ -132,6 +132,8 @@
 			if self.actor:knowTalent(t.id) and t.mode ~= "passive" then
 				local typename = "talent"
 				if t.type[1]:find("^spell/") then typename = "spell" end
+				if self.actor:isTalentActive(t.id) then typename = typename..", active" end
+				if self.actor:isTalentCoolingDown(t) then typename = typename.." - "..self.actor:isTalentCoolingDown(t) end
 				list[#list+1] = { name=self:makeKey(letter)..")    "..t.name.." ("..typename..")", talent=t.id }
 				keybind[self:makeKey(letter)] = #list + 1
 				if not self.sel then self.sel = #list + 1 end

EDIT: Modified the UseTalents diff to include a cooling down indicator in the m-menu.

[Chattius]

Yes cooldown in m-menu would be nice too. Never had this much combat arts i really use before i played a shadow blade.

[darkgod]

Done