is_combat flag on talents.

All development conversation and discussion takes place here

Moderator: Moderator

Post Reply
Message
Author
grayswandir
Uruivellas
Posts: 708
Joined: Wed Apr 30, 2008 5:55 pm

is_combat flag on talents.

#1 Post by grayswandir »

There's an is_spell flag to mark a talent as using spell speed, and an is_mind flag to mark a talent as using mind speed, but no way to mark something as using combat speed. Right now the game just assumes that anything in a technique category uses combat speed - so stuff like Dirty Fighting and Ice Claw ignore combat speed, since they're not in a 'technique' category.

So an is_combat flag would be nice. Or at least some way to control it on an individual talent level, aside from manually coding the speed.
Addons: Arcane Blade Tweaks, Fallen Race, Monk Class, Weapons Pack
Currently working on Elementals. It's a big project, so any help would be appreciated. :)

Sebsebeleb
Cornac
Posts: 33
Joined: Sun Apr 28, 2013 1:43 pm

Re: is_combat flag on talents.

#2 Post by Sebsebeleb »

How about going a step further and instead just have a parameter like "speed", that can be one of "combat" "spell" "mind OR be a function that returns the energy to use?

Doctornull
Sher'Tul Godslayer
Posts: 2402
Joined: Tue Jun 18, 2013 10:46 pm
Location: Ambush!

Re: is_combat flag on talents.

#3 Post by Doctornull »

Sebsebeleb wrote:How about going a step further and instead just have a parameter like "speed", that can be one of "combat" "spell" "mind OR be a function that returns the energy to use?
This is a really good idea.

Currently we have:
no_energy = "fake"

Suggest that the expansion be:
no_energy = "melee" (uses your current melee weapon(s) to calculate, or your off-set if you're not holding a melee weapon)
no_energy = "ranged" (uses your current ranged weapon to calculate, or your off-set if you're not holding a ranged weapon)
no_energy = "combat" (uses whatever is currently equipped)

... or we could totally replace the no_energy hack with something else, but that's a bunch of work for DarkGod.
Check out my addons: Nullpack (classes), Null Tweaks (items & talents), and New Gems fork.

grayswandir
Uruivellas
Posts: 708
Joined: Wed Apr 30, 2008 5:55 pm

Re: is_combat flag on talents.

#4 Post by grayswandir »

I ended up adding a 'speed' parameter, which can be: standard, combat, spell, summon, mind, movement, mainhand, offhand, weapon (slower of the two), and archery (like weapon but only for archery weapons).
no_energy still overrides it. If no_energy = 'fake', it'll just determine what the talent displays its speed as.

The tooltips now compensate for the various action speeds. For example, a melee talent with a quick weapon equipped:
Usage Speed: Weapon (90% of a turn)

You can also specify 'display_speed' to override the part after 'Usage Speed: '
Addons: Arcane Blade Tweaks, Fallen Race, Monk Class, Weapons Pack
Currently working on Elementals. It's a big project, so any help would be appreciated. :)

Zireael
Archmage
Posts: 449
Joined: Tue Jun 18, 2013 7:24 pm

Re: is_combat flag on talents.

#5 Post by Zireael »

Thanks a lot, grayswandir.

Post Reply