ToME: the Tales of Maj'Eyal

Everything about ToME
It is currently Thu Dec 03, 2020 11:05 pm

All times are UTC




Post new topic Reply to topic  [ 14 posts ] 
Author Message
 Post subject: Wisp Class
PostPosted: Thu Nov 12, 2020 5:30 am 
Offline
Thalore

Joined: Mon Jul 30, 2018 8:41 pm
Posts: 130
Hello everyone.
This addon introduces a new class, the Wisp.
You can download it here: https://te4.org/games/addons/tome/classwisp

Wisps are Psionic Archers, but they do not use the Beyond-the-Flesh psionic archery that adventurers are capable of.

Please report any bugs you find; I'll try to fix them.


Top
 Profile  
 
 Post subject: Re: Wisp Class
PostPosted: Thu Nov 12, 2020 11:11 pm 
Offline
Thalore

Joined: Wed Sep 28, 2016 8:07 pm
Posts: 157
Learning or unlearning telekinetic supremacy while unleash nightmare is known unlearns unleash nightmare, but doesn't refund the category point or unlearn the talents.

Also happens in the opposite direction with cosmic awareness.

Edit: glanced through the code and it seems like it should be pretty easy to fix by superloading updateTooltip in levelupdialog to recreate trees


Top
 Profile  
 
 Post subject: Re: Wisp Class
PostPosted: Fri Nov 13, 2020 4:40 pm 
Offline
Cornac

Joined: Mon Apr 20, 2020 5:58 pm
Posts: 31
nice to see you again.
Pinpoint Targetting is powerful, I love this design.
the picture of Thread Wall is wrong,web is above their real location.
when I use Drill Shot shoot seven enemies on a line, something crazy happened. the seventh one takes 16476 damage! Holy! I think the problem is that on-hit damage will always increase after pierce through an enemy.


Top
 Profile  
 
 Post subject: Re: Wisp Class
PostPosted: Sat Nov 14, 2020 3:26 am 
Offline
Thalore

Joined: Mon Jul 30, 2018 8:41 pm
Posts: 130
v0.1.2
  • Pinpoint Targeting no longer stacks on piercing attacks.
  • Fascinate duration fixed, had been too long
  • Fixed Bleed damage tooltip
  • Updated Pinpoint Targeting description to mention scaling.
  • Fixed typos
  • Can't learn an Unleash tree's first talent if you know the other tree.
  • Possible fix for thread wall appearing in the wrong place; I could never reproduce this myself.


Top
 Profile  
 
 Post subject: Re: Wisp Class
PostPosted: Tue Nov 17, 2020 11:41 pm 
Offline
Low Yeek

Joined: Mon Feb 27, 2012 9:11 pm
Posts: 8
Thanks for the addon! Interesting class, especially the advanced trees.

After getting Inner Demons'd I get swamped with Lua errors. > a dozen each turn. This is the error message.

I have other addons running. Here's the character if you think the class alone isn't the culprit.

Cheers!

edit: there might be a bug with proc damage or I just don't understand how things work.

Image

The nature damage is from a quiver of grasping which lists 207 nature damage. As I understand, proc damage isn't affected by weapon damage modifiers on talents etc. so we can ignore that. I have +7% nature damage so it goes to 221. I have 88 accuracy at that moment, so proc damage bonus will at most be +220% for 707 damage. The proc also got a crit, I only have 150% multi so it should total 1060 damage... right? I don't get how it got 2.5x'd again.

(oh, does accuracy bonus work against negative defence? I'm playing doomling so his defence might have dropped below 0).

edit: I think what's going on is the triggered arrow from Telekinetic Supremacy receives the proc damage bonus, because it's a proc. But then its own procs also receive the accuracy bonus again. This should probably be restricted to just one application of the accuracy bonus.


Top
 Profile  
 
 Post subject: Re: Wisp Class
PostPosted: Thu Nov 19, 2020 6:09 pm 
Offline
Thalore

Joined: Mon Jul 30, 2018 8:41 pm
Posts: 130
v0.1.3
  • Fixed a few bugs related to clones getting hit, clones dying, etc.
  • Fixed a bug where Telekinetic Supremacy got to double-up on proc damage bonus.
  • Fixed an unintended interaction where Telekinetic Supremacy got proc damage bonus on its weapon damage.
  • Idol abilities can consistently benefit from Range Amplification Device
  • Rares can spike Idol abilities

Negative Accuracy does contribute to proc damage bonus, but also it's capped at 80 accuracy difference.


Top
 Profile  
 
 Post subject: Re: Wisp Class
PostPosted: Fri Nov 27, 2020 3:57 am 
Offline
Low Yeek

Joined: Mon Nov 09, 2020 1:30 am
Posts: 9
I'm not entirely clear wtf happened here but I used Death Dance (stnadard two-handed assault tree) on a Nalore Trench Strider and got an error citing this mod. Maybe there was a rare nearby, but I haven't found it. Wasn't a game-killer and so far it's only a one-off.

Code:
[LOG]   #{bold}##UID:6522:0##fbd578#Melari Nightspear#LAST# performs a melee critical strike against Ogre mauler!#{normal}#
##Use Talent Lua Error##   T_DEATH_DANCE_ASSAULT   Actor:   6522   Melari Nightspear
Lua Error: /engine/interface/ActorTalents.lua:351: /engine/interface/ActorTalents.lua:324: /engine/interface/ActorTalents.lua:190: /hooks/classwisp/load.lua:33: attempt to index local 'target' (a nil value)
stack traceback:
   /hooks/classwisp/load.lua:33: in function </hooks/classwisp/load.lua:27>
   [string "return function(l, self, data) local ok=false..."]:1: in function 'triggerHook'
   /data/damage_types.lua:158: in function 'defaultProjector'
   /data/damage_types.lua:764: in function 'projector'
   /mod/class/interface/Combat.lua:624: in function 'attackTargetWith'
   /mod/addons/cults/superload/mod/class/interface/Combat.lua:30: in function 'attackTargetWith'
   /data/talents/techniques/2h-assault.lua:146: in function 'damtype'
   /engine/interface/ActorProject.lua:258: in function 'project'
   /data/talents/techniques/2h-assault.lua:142: in function </data/talents/techniques/2h-assault.lua:129>
   [C]: in function 'xpcall'
   /engine/interface/ActorTalents.lua:186: in function </engine/interface/ActorTalents.lua:173>
   At [C]:-1
   At [C]:-1 error
   At /engine/interface/ActorTalents.lua:351 useTalent
   At /engine/interface/PlayerHotkeys.lua:179
   At /engine/interface/PlayerHotkeys.lua:162 activateHotkey
   At /mod/class/Game.lua:2526 fct
   At /engine/interface/PlayerHotkeys.lua:326
   At /engine/KeyBind.lua:231


Top
 Profile  
 
 Post subject: Re: Wisp Class
PostPosted: Fri Nov 27, 2020 1:28 pm 
Offline
Cornac

Joined: Mon Apr 20, 2020 5:58 pm
Posts: 31
Syovere wrote:
I'm not entirely clear wtf happened here but I used Death Dance (stnadard two-handed assault tree) on a Nalore Trench Strider and got an error citing this mod. Maybe there was a rare nearby, but I haven't found it. Wasn't a game-killer and so far it's only a one-off.

DO NOT active several class addons at once,This is common sense, my friend.


Top
 Profile  
 
 Post subject: Re: Wisp Class
PostPosted: Fri Nov 27, 2020 3:50 pm 
Offline
Uruivellas

Joined: Mon Sep 21, 2015 8:45 pm
Posts: 947
Location: Middle of Nowhere
Running lots of add-ons of any kind has the potential to lead to conflicts. That said, if things are done right then such conflicts can nearly always be avoided. Recaiden (Wisp), Astral (Trench Strider), and myself (Naloren) are all active modders and, while I can't speak for the two, I at least like to know of any error where my mod is mentioned, even if it may not be at fault. That way it can at least be investigated to determine if it is a conflict or an actual error in that add-on alone.

That is just to say, don't feel like you should write off any error that comes up while running multiple class add-ons. I think in general most add-on creators would still appreciate the report; I know I certainly would :)


Top
 Profile  
 
 Post subject: Re: Wisp Class
PostPosted: Fri Nov 27, 2020 9:00 pm 
Offline
Low Yeek

Joined: Mon Nov 09, 2020 1:30 am
Posts: 9
Seventeer wrote:
Syovere wrote:
I'm not entirely clear wtf happened here but I used Death Dance (stnadard two-handed assault tree) on a Nalore Trench Strider and got an error citing this mod. Maybe there was a rare nearby, but I haven't found it. Wasn't a game-killer and so far it's only a one-off.

DO NOT active several class addons at once,This is common sense, my friend.

I've been doing it since 1.2 with very few problems, piss off with your "common sense" BS. The vast majority of class and race addons I've used over the years (this is not my original forum account) have had no compatibility issues at all.


Top
 Profile  
 
 Post subject: Re: Wisp Class
PostPosted: Sat Nov 28, 2020 5:31 am 
Offline
Cornac

Joined: Mon Apr 20, 2020 5:58 pm
Posts: 31
Syovere wrote:
Seventeer wrote:
Syovere wrote:
I'm not entirely clear wtf happened here but I used Death Dance (stnadard two-handed assault tree) on a Nalore Trench Strider and got an error citing this mod. Maybe there was a rare nearby, but I haven't found it. Wasn't a game-killer and so far it's only a one-off.

DO NOT active several class addons at once,This is common sense, my friend.

I've been doing it since 1.2 with very few problems, piss off with your "common sense" BS. The vast majority of class and race addons I've used over the years (this is not my original forum account) have had no compatibility issues at all.


Recaiden (Wisp), Astral (Trench Strider),They have no responsibility to combine with other addons.


Top
 Profile  
 
 Post subject: Re: Wisp Class
PostPosted: Sat Nov 28, 2020 5:48 am 
Offline
Thalore

Joined: Mon Jul 30, 2018 8:41 pm
Posts: 130
Hey, calm down.
nsrr is completely right. Wisp should totally be usable alongside other addons. And if all I find out is "there's a conflict with X addon", that's good to know.

What's happened here is damage being dealt to....no one. This would have had no effect on the game, but the new version fixes the error popup.


Top
 Profile  
 
 Post subject: Re: Wisp Class
PostPosted: Sat Nov 28, 2020 6:45 am 
Offline
Low Yeek

Joined: Mon Nov 09, 2020 1:30 am
Posts: 9
Seventeer wrote:
Recaiden (Wisp), Astral (Trench Strider),They have no responsibility for your own choice,have no responsibility to combine with other addons.

The post about the addon makes no statements about incompatibilities. Therefore, I will report any issues I find, even if for no other reason than so other users can be informed.

Moving along.

Thank you, Recaiden. I'm grabbing the update now.


Top
 Profile  
 
 Post subject: Re: Wisp Class
PostPosted: Sun Nov 29, 2020 10:05 am 
Offline
Cornac

Joined: Mon Apr 20, 2020 5:58 pm
Posts: 31
It means that bug will always happens even without any other add? I got it.
Syovere wrote:
Moving along.
Thank you, Recaiden. I'm grabbing the update now.

You win the argument. I apologize for what I said.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 14 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group