ToME: the Tales of Maj'Eyal

Everything about ToME
It is currently Tue Aug 22, 2017 2:56 pm

All times are UTC




Post new topic Reply to topic  [ 24 posts ]  Go to page 1, 2  Next
Author Message
 Post subject: Slow Tweak v1.2.0
PostPosted: Fri Dec 30, 2016 12:50 am 
Offline
Spiderkin

Joined: Mon Sep 21, 2015 8:45 pm
Posts: 485
Location: Middle of Nowhere
Here and on the Steam workshop.

Tweaks the 'Slow' effect such that when a new slow is applied to a target already afflicted with a slow, the new slow will no longer outright replace the old effect. Instead, the highest power effect will take priority. If the new effect is stronger, it will replace the old effect. Otherwise, it will be ignored.

This is primarily intended to resolve the issues caused by equipping multiple pieces of gear with on-hit slows. Due to the way Slow normally works, only the last effect applied will have any impact on the target. The result is that equipping more pieces of gear with on-hit slow can detrimentally impact your ability to slow enemies, which is counter-intuitive and less than ideal.

This refers specifically to the effect 'Slow', which reduces global speed. Other effects which influence speed, global or otherwise, are not affected by this addon.


Last edited by nsrr on Tue Jan 03, 2017 2:58 pm, edited 1 time in total.

Top
 Profile  
 
 Post subject: Re: Slow Tweak v1.1.0
PostPosted: Fri Dec 30, 2016 11:33 am 
Offline
Sher'Tul Godslayer

Joined: Mon Feb 14, 2011 11:16 pm
Posts: 2245
There are two melee slow effects: XX% to cause slow and Slow by YY%. Does it handle both types?

_________________
MADNESS rocks


Top
 Profile  
 
 Post subject: Re: Slow Tweak v1.1.0
PostPosted: Fri Dec 30, 2016 1:04 pm 
Offline
Thalore

Joined: Thu May 21, 2015 10:28 pm
Posts: 147
Also does this work with oozemancer?

They have 40% slow built into slime spit, but ooze beam has 15% slow and overrides it all the time


Top
 Profile  
 
 Post subject: Re: Slow Tweak v1.1.0
PostPosted: Fri Dec 30, 2016 1:24 pm 
Offline
Spiderkin

Joined: Mon Sep 21, 2015 8:45 pm
Posts: 485
Location: Middle of Nowhere
This will affect anything that uses the Slow status. I know Slime Spit uses Slow, so Oozebeam must as well, if it normally overwrites. So, yes, that should be covered.

Same for on-hit effects. If they apply Slow, this will affect them. This definetly includes 'slow by xx%' on-hit effects, as this was my primary focus in testing. I'm not sure about 'xx% chance to slow'... that's not an effect I actually remember. Unless you mean chance to cripple? Cripple affects all combat (mind, spell, attack) speeds, but not global speed, and is a different effect from Slow. It would not be affected.


Top
 Profile  
 
 Post subject: Re: Slow Tweak v1.1.0
PostPosted: Sat Dec 31, 2016 11:39 am 
Offline
Sher'Tul Godslayer

Joined: Mon Feb 14, 2011 11:16 pm
Posts: 2245
Slow global speed by XX% is on two antimagic egos: slime-covered and of the leech

_________________
MADNESS rocks


Top
 Profile  
 
 Post subject: Re: Slow Tweak v1.1.0
PostPosted: Sat Dec 31, 2016 1:00 pm 
Offline
Spiderkin

Joined: Mon Sep 21, 2015 8:45 pm
Posts: 485
Location: Middle of Nowhere
jenx wrote:
Slow global speed by XX% is on two antimagic egos: slime-covered and of the leech


Then, yes, covers both of those.

Slime-covered just has a chance to apply the Slow status.

Leech has a few effects. One is on-hit Slime damage. The Slime damage type is Nature damage with Slow built in. It's the same damage type used by Slimespit, for example. It doesn't specify the slow power, so it's probably the standard 15%. Leech also has a chance drain Stamina, and a chance to inflict Slow on-hit. I honestly couldn't tell you which would normally apply first in that case. If the wiki is right, the Slime damage is for all melee hits, not just the weapon with the ego, and those effects usually seem to hit last. In either case, the Slow status is being used all around, so with this tweak it won't matter which order they hit in. Only the strongest will be relevant.


Top
 Profile  
 
 Post subject: Re: Slow Tweak v1.1.0
PostPosted: Tue Jan 03, 2017 1:43 pm 
Offline
Sher'Tul Godslayer

Joined: Mon Feb 14, 2011 11:16 pm
Posts: 2245
Could this addon be wrecking global character speed?

http://te4.org/characters/2460/tome/dfe ... 62b1ed8d89

I have yeek adventurer with Essence of Speed 5/5 and Quickened 2/5, and my global speed is 103.3% !!!!

It all went haywire when I got Quickened, the Yeek racial ability. I have made lots of chars like this and never had this happen before.

If it's not the addon, I have no idea what has caused it :-(

_________________
MADNESS rocks


Last edited by jenx on Tue Jan 03, 2017 1:51 pm, edited 1 time in total.

Top
 Profile  
 
 Post subject: Re: Slow Tweak v1.1.0
PostPosted: Tue Jan 03, 2017 1:50 pm 
Offline
Wyrmic

Joined: Tue Feb 10, 2015 1:41 pm
Posts: 284
It's possible that the addon new slows don't clean themselves correctly once removed (say, you apply a 15% slow, then upgrade it to 30%, then the slow ends and it only removes the original 15%). It's not much of a problem for NPCs since death is usually the removal cause, but for the player those errors accumulate fast :D


Top
 Profile  
 
 Post subject: Re: Slow Tweak v1.1.0
PostPosted: Tue Jan 03, 2017 2:06 pm 
Offline
Spiderkin

Joined: Mon Sep 21, 2015 8:45 pm
Posts: 485
Location: Middle of Nowhere
Well, that's no good...

I'll look into this immediately.


Top
 Profile  
 
 Post subject: Re: Slow Tweak v1.2.0
PostPosted: Tue Jan 03, 2017 2:57 pm 
Offline
Spiderkin

Joined: Mon Sep 21, 2015 8:45 pm
Posts: 485
Location: Middle of Nowhere
Mordy hit the nail on the head; slows weren't being removed properly due to some poor coding on my part.

This has been fixed in v1.2.0, now up.

I apologize for the mistake, and thanks for letting me know.


Top
 Profile  
 
 Post subject: Re: Slow Tweak v1.2.0
PostPosted: Tue Jan 03, 2017 11:13 pm 
Offline
Sher'Tul Godslayer

Joined: Mon Feb 14, 2011 11:16 pm
Posts: 2245
nsrr wrote:
Mordy hit the nail on the head; slows weren't being removed properly due to some poor coding on my part.

This has been fixed in v1.2.0, now up.

I apologize for the mistake, and thanks for letting me know.


Thank you for fixing it!

Will my char now work, or do I have to restart?

Edit: Answer, it doesn't work :-(

_________________
MADNESS rocks


Top
 Profile  
 
 Post subject: Re: Slow Tweak v1.2.0
PostPosted: Wed Jan 04, 2017 12:11 am 
Offline
Sher'Tul Godslayer

Joined: Mon Feb 14, 2011 11:16 pm
Posts: 2245
I updated the addon and rolled a new char. I got a lua error, not from this addon but from marksman. But I've played dozens of hours using marksman with no errors, so it is possibly this addon?

or an edge case with marksman, but I doubt it tbh.

here is the error:

Code:
error = "Lua Error: /engine/interface/ActorTalents.lua:279: /engine/interface/ActorTalents.lua:256: /engine/interface/ActorTalents.lua:150: /data-marksman/talents/techniques/archery-prowess_raz.lua:187: attempt to index local 'target' (a nil value)\
stack traceback:\
\9/data-marksman/talents/techniques/archery-prowess_raz.lua:187: in function </data-marksman/talents/techniques/archery-prowess_raz.lua:146>\
\9[C]: in function 'xpcall'\
\9/engine/interface/ActorTalents.lua:147: in function </engine/interface/ActorTalents.lua:140>\
  At [C]:-1 \
  At [C]:-1 error\
  At /engine/interface/ActorTalents.lua:279 useTalent\
  At /engine/interface/PlayerHotkeys.lua:170 \
  At /engine/interface/PlayerHotkeys.lua:162 activateHotkey\
  At /engine/HotkeysIconsDisplay.lua:384 onMouse\
  At /mod/class/uiset/Minimalist.lua:1785 fct\
  At /engine/Mouse.lua:58 "
seen = true
reported = true

_________________
MADNESS rocks


Top
 Profile  
 
 Post subject: Re: Slow Tweak v1.2.0
PostPosted: Wed Jan 04, 2017 12:23 pm 
Offline
Spiderkin

Joined: Mon Sep 21, 2015 8:45 pm
Posts: 485
Location: Middle of Nowhere
Yes, unfortunately, the error is not something I can correct retroactively. Again, my apologies. I lost a couple of characters as well, if it makes you feel better.

As for that error, I can't see anything that Slow Tweak would have to do with it. Judging from the code, I think it's fairly likely that is an edge case error. The talent that fired the error was Volley, and it looks like it builds a list of secondary targets and then attacks them one at a time. It doesn't check to see if they are still alive, though, so it could throw an error like this if one of the secondary targets was killed by on-hit burst damage from the Volley attack made against another target within the burst range. I could be wrong about the exact cause, but either way, I'm pretty confident this is all Marksman. Could you post the error in the Marksman thread so Razakai can take a look?


Top
 Profile  
 
 Post subject: Re: Slow Tweak v1.2.0
PostPosted: Thu Jan 05, 2017 6:57 pm 
Offline
Sher'Tul Godslayer

Joined: Mon Feb 14, 2011 11:16 pm
Posts: 2245
Yikes! I think there is something wrong with the addon...

I am battling the Master and he has Reflexive Dodging, granting him 354% global speed increase.

My attacks have given him:
Imploding slow (slowed by 50%)
Slowed by the gloom (slowed by 30%)

His global speed is 373.7% !!!!

Is this right?

_________________
MADNESS rocks


Top
 Profile  
 
 Post subject: Re: Slow Tweak v1.2.0
PostPosted: Thu Jan 05, 2017 11:05 pm 
Offline
Spiderkin

Joined: Mon Sep 21, 2015 8:45 pm
Posts: 485
Location: Middle of Nowhere
I can't say for sure, really. Looks about right? Base speed of 100%, + 354% - 30% - 50% = approx. 374% ?


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 24 posts ]  Go to page 1, 2  Next

All times are UTC


Who is online

Users browsing this forum: No registered users and 3 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group