ToME: the Tales of Maj'Eyal

Everything about ToME
It is currently Fri Aug 17, 2018 10:52 am

All times are UTC




Post new topic Reply to topic  [ 31 posts ]  Go to page 1, 2, 3  Next
Author Message
PostPosted: Sun Mar 31, 2013 11:51 pm 
Offline
Sher'Tul Godslayer

Joined: Thu Jan 23, 2003 8:13 pm
Posts: 1553
Location: A shallow water area south of Bree
So my Alchemist got tired of his gems being scattered haphazardly throughout his inventory and not in tier order. Did a bit of digging and found out that the default ActorInventory:sortInven() is pretty anemic. Hence my new Inventory Sort Order addon.

Here's the lowdown on the new sort order:
  • Default ordering is by type, subtype, material level and name, except for a couple exceptions noted below. Type and subtype are listed in the item description tooltip, like "weapon/mace" or "armor/light".
  • The sort order for types is as follows: potion, scroll (covering runes and infusions), jewelry, weapon, ammo, armor, gem, alchemist-gem, lite, lore, misc, money, tool, orb, chest, charm, totem, mount, and the rest alphabetically by type name. [This is where the default ordering falls down; it only covers a few types, and lumps the rest together unsorted by type.]
  • Subtype is sorted alphabetically by subtype name. One exception: within the weapon type, bows and slings sort after other weapons.
  • We make an exception for gems and alchemist gems, which are sorted by tier before subtype (since for gems, subtype is just color).

I'm putting this out for feedback, both on the ordering and on whether to merge this into ZOmnibus.

[edit 2013-11-13 12:23am: Technical info:]
Code:
Superload:
  mod.class.Player:
    showInven() [overloaded, to replace the sort method]

_________________
"Blessed are the yeeks, for they shall inherit Arda..."


Last edited by Zizzo on Wed Nov 13, 2013 5:23 am, edited 2 times in total.

Top
 Profile  
 
PostPosted: Mon Apr 01, 2013 11:52 am 
Offline
Thalore

Joined: Thu Jan 17, 2013 2:49 pm
Posts: 190
Finally :) I always hated trying to find the right gem!


Top
 Profile  
 
PostPosted: Wed Apr 10, 2013 12:56 am 
Offline
Sher'Tul Godslayer

Joined: Thu Jan 23, 2003 8:13 pm
Posts: 1553
Location: A shallow water area south of Bree
Pushing out v1a with a small bugfix involving sorting items that don't define a subtype or material level (aka. 'tier'). And since I didn't get any objections, I'm going ahead and merging this addon into ZOmnibus; if you're a ZOmnibus user and particularly attached to the game's current sort order, speak now or forever hold your proverbial peace. :wink:

_________________
"Blessed are the yeeks, for they shall inherit Arda..."


Top
 Profile  
 
PostPosted: Sat Apr 27, 2013 4:16 am 
Offline
Uruivellas

Joined: Tue Feb 17, 2004 4:43 pm
Posts: 610
This would be very useful. One question...is it possible to tweak inventory to recognize the keyboard letters, i.e. press "j" to select whatever item is listed as "j"? I find scrolling extraordinarily tedious, even with ordered inventory, when converting gems to alchemist gems since there's no batch convert option (thanks to the mana cost, which probably should be removed anyway.) By the middle to late game, unless I dilgently convert at regular intervals, converting 30 diamonds, for instance, is just an exercise in tedium and scrolling.

In fact, I'm going to post the suggestion of removing mana cost and allowing us to select a # of gems over in Ideas.


Top
 Profile  
 
PostPosted: Sat Apr 27, 2013 10:54 pm 
Offline
Sher'Tul Godslayer

Joined: Thu Jan 23, 2003 8:13 pm
Posts: 1553
Location: A shallow water area south of Bree
Hunter wrote:
One question...is it possible to tweak inventory to recognize the keyboard letters, i.e. press "j" to select whatever item is listed as "j"? I find scrolling extraordinarily tedious, even with ordered inventory, when converting gems to alchemist gems since there's no batch convert option (thanks to the mana cost, which probably should be removed anyway.) By the middle to late game, unless I dilgently convert at regular intervals, converting 30 diamonds, for instance, is just an exercise in tedium and scrolling.

I'll look into it. It'll probably end up being a separate addon, since there's no longer any de facto memory-based limitation to having lots of addons.

In the meantime, you might find my Use Item Shortcuts addon useful. I think (haven't tested) that your stack of 30 [->29] diamonds would remain selected after you used "Convert to alchemist gems" from the "Use Item" popup, which would at least save you some keystrokes.

_________________
"Blessed are the yeeks, for they shall inherit Arda..."


Top
 Profile  
 
PostPosted: Sun Apr 28, 2013 5:42 pm 
Offline
Uruivellas

Joined: Tue Feb 17, 2004 4:43 pm
Posts: 610
Thanks. The letter thing occurred to me because I've noticed it being available in certain other aspects of the game (the latest being purchasing special items from the merchant) so I know the mechanic exists somewhere. I'll test this current download and see if it helps, especially the next time I start an alchemist.


Top
 Profile  
 
PostPosted: Fri May 10, 2013 3:20 am 
Offline
Sher'Tul Godslayer

Joined: Thu Jan 23, 2003 8:13 pm
Posts: 1553
Location: A shallow water area south of Bree
And migrating to v1.0.3.

_________________
"Blessed are the yeeks, for they shall inherit Arda..."


Top
 Profile  
 
PostPosted: Sat May 11, 2013 2:05 pm 
Offline
Sher'Tul Godslayer

Joined: Thu Jan 23, 2003 8:13 pm
Posts: 1553
Location: A shallow water area south of Bree
So remember I said above that bows and slings were supposed to be sorted below other weapons? Well, I just noticed that the type/subtype of bows is actually weapon/longbow, and my code was looking for weapon/bow, so that wasn't getting sorted properly. :oops: Pushing out v1c to fix that. We Apologize for the Inconvenience.(TM)

_________________
"Blessed are the yeeks, for they shall inherit Arda..."


Top
 Profile  
 
PostPosted: Wed May 22, 2013 1:41 am 
Offline
Sher'Tul Godslayer

Joined: Thu Jan 23, 2003 8:13 pm
Posts: 1553
Location: A shallow water area south of Bree
And migrating to v1.0.4.

_________________
"Blessed are the yeeks, for they shall inherit Arda..."


Top
 Profile  
 
PostPosted: Sat Jun 29, 2013 6:34 pm 
Offline
Sher'Tul Godslayer

Joined: Thu Jan 23, 2003 8:13 pm
Posts: 1553
Location: A shallow water area south of Bree
Pushing out bugfix release 1e; turns out there's an artifact gem in the endgame that was choking my sorting code.

_________________
"Blessed are the yeeks, for they shall inherit Arda..."


Top
 Profile  
 
PostPosted: Wed Nov 13, 2013 5:22 am 
Offline
Sher'Tul Godslayer

Joined: Thu Jan 23, 2003 8:13 pm
Posts: 1553
Location: A shallow water area south of Bree
And migrating to v1.0.5.

_________________
"Blessed are the yeeks, for they shall inherit Arda..."


Top
 Profile  
 
PostPosted: Sat Dec 07, 2013 10:48 pm 
Offline
Sher'Tul Godslayer

Joined: Tue Jun 18, 2013 10:46 pm
Posts: 2275
Location: Ambush!
I would like some way to group gems by (color,tier) so basically all the blue ones are together, and they are in tier order. This is because when I want a blue gem, what I actually want is my current best blue gem.

Appending the tier number to the subtype string could accomplish this, maybe? So a gem's subtype might read "blue / 3".

_________________
Check out my addons: Nullpack (classes), Null Tweaks (items & talents), and New Gems fork.


Top
 Profile  
 
PostPosted: Mon Dec 09, 2013 2:43 am 
Offline
Sher'Tul Godslayer

Joined: Thu Jan 23, 2003 8:13 pm
Posts: 1553
Location: A shallow water area south of Bree
Doctornull wrote:
I would like some way to group gems by (color,tier) so basically all the blue ones are together, and they are in tier order. This is because when I want a blue gem, what I actually want is my current best blue gem.

? Why would you want a blue gem in particular? At any rate, the easiest approach is probably a game option to control the behavior. I've pushed that out in v1g; the new option is "Sort gems by tier", and toggles between sorting gems by tier then color or by color then tier.

_________________
"Blessed are the yeeks, for they shall inherit Arda..."


Top
 Profile  
 
PostPosted: Mon Dec 09, 2013 3:29 am 
Offline
Sher'Tul Godslayer

Joined: Tue Jun 18, 2013 10:46 pm
Posts: 2275
Location: Ambush!
Zizzo wrote:
? Why would you want a blue gem in particular? At any rate, the easiest approach is probably a game option to control the behavior. I've pushed that out in v1g; the new option is "Sort gems by tier", and toggles between sorting gems by tier then color or by color then tier.
I play using the New Gems addon, which makes all gem effects consistent within a color -- and higher tier gems are strictly better than those of lower tiers

So, the blue gems are the +stat gems. If I want higher stats, then I want a blue gem, and specifically I want my best blue gem. Similarly, if I want an armor boost, I want my best white gem.

_________________
Check out my addons: Nullpack (classes), Null Tweaks (items & talents), and New Gems fork.


Top
 Profile  
 
PostPosted: Mon Dec 09, 2013 4:25 am 
Offline
Sher'Tul Godslayer

Joined: Tue Jun 18, 2013 10:46 pm
Posts: 2275
Location: Ambush!
Zizzo wrote:
I've pushed that out in v1g; the new option is "Sort gems by tier", and toggles between sorting gems by tier then color or by color then tier.
It doesn't seem to be working :(

Neither selection makes the imbue gem screen sort them as I'd hope.


Attachments:
File comment: Disabled (imbue gem screen)
Screen Shot 2013-12-08 at 11.22.21 PM.png
Screen Shot 2013-12-08 at 11.22.21 PM.png [ 171.31 KiB | Viewed 4572 times ]
File comment: Enabled (imbue gem screen)
Screen Shot 2013-12-08 at 11.21.04 PM.png
Screen Shot 2013-12-08 at 11.21.04 PM.png [ 214.35 KiB | Viewed 4572 times ]

_________________
Check out my addons: Nullpack (classes), Null Tweaks (items & talents), and New Gems fork.
Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 31 posts ]  Go to page 1, 2, 3  Next

All times are UTC


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group