ToME: the Tales of Maj'Eyal
http://forums.te4.org/

[ToME 1.5.10] Sun Ray doesn't get removed properly
http://forums.te4.org/viewtopic.php?f=42&t=49024
Page 1 of 1

Author:  BugReporter [ Fri Jun 08, 2018 6:05 pm ]
Post subject:  [ToME 1.5.10] Sun Ray doesn't get removed properly

I have found a mention of this issue in an old topic in Bugs (viewtopic.php?f=42&t=43925&hilit=sun+ray), but no report in this part of the forum. The issue is still relevant, thus I decided to post this.

Short description.
Sun Ray doesn't get removed properly.
Actual result.
Sun paladin's Sun Ray visual effect remains after casting, but it is only visible after zone change or game load.
Expected result.
Sun paladin's Sun Ray visual effect should not remain after casting.
Steps to reproduce.
Change level method.
1. Create a Sun paladin character with 1 point in Sun Ray.
2. In Gates of Morning move to the "Way into the Slazish fens" tile.
3. Cast Sun Ray on several nearby tiles.
4. Change level to Slazish fens (1).
5. Cast Sun Ray on several nearby tiles.
6. Now you can change levels Gates of Morning <-> Slazish fens (1) and observe the remains of past Sun Rays.
Game load method.
1. Create a Sun paladin character with 1 point in Sun Ray.
2. Cast Sun Ray on several nearby tiles.
3. Go to main menu (optionally exit the game).
4. Load the game and observe the remains of past Sun Rays.
Game version.
1.5.9 and 1.5.10 for windows from ToME site.
Comment.
At first I thought that was a graphical issue, but further tests led me to believe that my assumption was not correct.
Several things I could find out:
1. The issue persists after game restarts.
2. The issue increases the size of the save file.
3. Setting OpenGL Shaders: Advanced to disabled prevents the graphical part of the bug as well as save files growth.
4. Visual effects obtained with OpenGL Shaders: Advanced enabled remain after disabling the option.
5. Remains of Sun ray do no damage to the player character, friendly units, enemies.
6. Repeated use of the talent on the same spot "stack".

There is some test data that may or may not be useful. Let me provide you with some numbers: 15, 94, 73, 46. Hmm... these seem to be the wrong ones. Oh, there they are. :P
Test method:
Character: cornac level 1 Sun paladin. Stats no points added. Added 1 point to Healing light. Talents: Heavy armour training 2, Chant acolyte 1, Healing light 1, Weapon of light 1, Sun ray 1.
Character moves to "Way into the Slazish fens" tile -> Wait for energy to reach 0 -> Change level(to SF1) -> Change level(to GoM) -> Save.
Several more level changes were required until I got more or less stable size values for save files (game.teag, zone-slazish-fen.teaz, zone-town-gates-of-morning.teaz): (828 KB, 98 KB, 532 KB).
The cycle: Use a talent X (wait for energy to reach 0, talents off cd) -> Change level(to SF1) -> Use a talent X (wait for energy to reach 0, talents off cd)-> Change level(to GoM) -> observe save game files size.

OpenGL Shaders: Advanced disabled. The 3rd attempt provided almost the same results therefore I skipped that.
Code:
Talent                  Save game files size (game.teag, zone-slazish-fen.teaz, zone-town-gates-of-morning.teaz)

1st attempt.
Start                   (828 KB,  98 KB, 532 KB)
Healing light x20       (830 KB,  98 KB, 529 KB)
Weapon of light x20     (833 KB,  98 KB, 532 KB)
Chant of fortitude x20  (833 KB,  98 KB, 534 KB)
Sun ray x20             (835 KB,  98 KB, 534 KB)
Regeneration x20        (831 KB,  98 KB, 536 KB)

2nd attempt.
Healing light x20       (834 KB,  98 KB, 532 KB)
Weapon of light x20     (834 KB,  98 KB, 535 KB)
Chant of fortitude x20  (836 KB,  98 KB, 534 KB)
Sun ray x20             (833 KB,  98 KB, 536 KB)
Regeneration x20        (833 KB,  98 KB, 533 KB)


OpenGL Shaders: Advanced enabled. Restarted the game. Several level changes to get more or less stable size values for save files.
Code:
1st attempt.
Start                   (837 KB, 100 KB, 542 KB)
Healing light x20       (847 KB, 100 KB, 535 KB)
Weapon of light x20     (842 KB, 100 KB, 545 KB)
Chant of fortitude x20  (846 KB, 100 KB, 540 KB)
Sun ray x20             (849 KB, 109 KB, 553 KB)
Regeneration x20        (849 KB, 109 KB, 547 KB)

2nd attempt
Healing light x20       (845 KB, 109 KB, 546 KB)
Weapon of light x20     (849 KB, 109 KB, 542 KB)
Chant of fortitude x20  (847 KB, 109 KB, 547 KB)
Sun ray x20             (862 KB, 118 KB, 554 KB)
Regeneration x20        (860 KB, 118 KB, 559 KB)

3rd attempt.
Healing light x20       (859 KB, 118 KB, 557 KB)
Weapon of light x20     (862 KB, 118 KB, 555 KB)
Chant of fortitude x20  (857 KB, 118 KB, 559 KB)
Sun ray x20             (866 KB, 126 KB, 562 KB)
Regeneration x20        (874 KB, 126 KB, 562 KB)


Other talents that can be affected by the same issue:
Maggot Breath from Demented/Scourge Drake (reported by Effigy viewtopic.php?f=42&t=49024#p232352).

Attachments:
OnFire.jpg
OnFire.jpg [ 16.47 KiB | Viewed 620 times ]
File comment: I think I begin to understand why they called this place Gates of Morning.
GatesOfMorningHuh.jpg
GatesOfMorningHuh.jpg [ 47.71 KiB | Viewed 620 times ]

Author:  Cathbald [ Fri Jun 08, 2018 8:18 pm ]
Post subject:  Re: [ToME 1.5.10] Sun Ray doesn't get removed properly

also true of several other effects though i'd have a hard time to name them right now...

Author:  BugReporter [ Sat Jun 09, 2018 8:30 pm ]
Post subject:  Re: [ToME 1.5.10] Sun Ray doesn't get removed properly

I see, thanks for bringing that up.

Some more info:
Changing true to false in L57 in data\gfx\particles\volumetric.lua seems to suppress the issue.
from
Code:
1, "particles_images/volumetric/"..(img or "circles_01"), true

to
Code:
1, "particles_images/volumetric/"..(img or "circles_01"), false

After a small test no sun ray remains were noticed and save files observations didn't reveal anything unusual. Consequences of this change are unknown. A quick search shows that volumetric is used in other files.
That's a hack, not a proper fix. As I really have no idea what I'm doing and where the issue originates from.

Edit. Probably unrelated. It was always visible. I think it is Feed.

Attachments:
feed.jpg
feed.jpg [ 24.28 KiB | Viewed 585 times ]

Author:  Effigy [ Thu Jun 14, 2018 6:19 am ]
Post subject:  Re: [ToME 1.5.10] Sun Ray doesn't get removed properly

Maggot Breath from Demented/Scourge Drake seems to have the same issue.

Author:  BugReporter [ Sat Jun 16, 2018 8:46 pm ]
Post subject:  Re: [ToME 1.5.10] Sun Ray doesn't get removed properly

Thanks. Added to the first post.

Page 1 of 1 All times are UTC
Powered by phpBB® Forum Software © phpBB Group
https://www.phpbb.com/