ToME: the Tales of Maj'Eyal

Everything about ToME
It is currently Sun Dec 17, 2017 6:22 am

All times are UTC




Post new topic Reply to topic  [ 3 posts ] 
Author Message
PostPosted: Tue May 23, 2017 12:51 pm 
Offline
Spiderkin

Joined: Mon Oct 09, 2006 7:47 pm
Posts: 576
Looking at the hidden blade/assassinate code in cunning/Artifice, I noticed that there is dual application of the same bleed damage.

in hiddenblade
Code:
newTalent{
        name = "Hidden Blades",
         ...
        callbackOnCrit = function(self, t, kind, dam, chance, target)
                       ...
                        local oldlife = target.life
                        ...
                        if self:knowTalent(self.T_ASSASSINATE) then
                                local scale = nil
                                scale = self:callTalent(self.T_ASSASSINATE, "getBleed")
                                local life_diff = oldlife - target.life
                                if life_diff > 0 and target:canBe('cut') and scale then
                                        target:setEffect(target.EFF_CUT, 5, {power=life_diff * scale / 5, src=self})
                                end
                        end
                        self:startTalentCooldown(t)
         ...
}


So hidden blade calls assassinate (if it is known), then applies a bleeding based on the life difference
But in assassinate....

Code:
newTalent{
        name = "Assassinate",
      ...
       action = function(self, t)
                ...
                local bleed = t.getBleed(self, t)
                local oldlife = target.life
                ...
                local do_attack = function() self:attackTarget(target, nil, t.getDamage(self, t), true, true) end
                ....               
                local life_diff = oldlife - target.life
                if life_diff > 0 and target:canBe('cut') and bleed then
                        target:setEffect(target.EFF_CUT, 5, {power=life_diff * bleed / 5, src=self})
                end

                return true
        end,
...
}:


... there is an attack and then the very same bleeding is also applied.

I assume this an error.


Top
 Profile  
 
PostPosted: Mon Jul 17, 2017 3:37 am 
Offline
Sher'Tul Godslayer

Joined: Mon Feb 14, 2011 11:16 pm
Posts: 2262
Interesting....I'm going to roll a rogue and check this out.

_________________
MADNESS rocks


Top
 Profile  
 
PostPosted: Mon Jul 17, 2017 8:31 am 
Offline
Uruivellas

Joined: Tue May 14, 2013 3:45 pm
Posts: 817
Not an error. The passive part of Assassinate causes Hidden Blades to inflict bleeding - and Assassinate is an attack using your Hidden Blades, and therefore causes it to bleed.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 3 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users and 3 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group