These bugs are not really important, but they were easy to fix, so I've fixed them.
I hope these fixes can be merged into trunk, so I'm also posting a diff between b41 and my addon, so you can inspect changes.
edit: I'm posting here instead of in Addon forum because I consider this addon not a real addon but a simple way to submit some fixes. Feel free to move it to Addon forum if you think that place is more appropriate.
edit2: added a new fix and replaced diff and zip files
[tome] joylove: You can't just release an expansion like one would release a Kraken XD
--
[tome] phantomfrettchen: your ability not to tease anyone is simply stunning
Here are some fixes for the introductory tips, found in the init.lua file in the mod directory.
< Old
> New
45c45
< You are an adventurer, set out to discover wonders, explore old places, and venture into the unknown for wealth and glory.
---
> You are an adventurer. Set out to discover wonders, explore old places, and venture into the unknown for wealth and glory.
85c85
< {image="/data/gfx/talents/thick_skin.png", text=[[The Thick Skin talent reducing all incoming damage, letting you survive for longer before needing to heal.]]},
---
> {image="/data/gfx/talents/thick_skin.png", text=[[The Thick Skin talent reduces all incoming damage, letting you survive for longer before needing to heal.]]},
95c95
< {image="/data/gfx/shockbolt/npc/patrol_allied_kingdoms_allied_kingdoms_halfling_patrol.png", text=[[The Nargol empire was once the largest force in Maj'Eyal, but a combination of the Spellblaze and orcish attacks have dwindled it into insignificance.]]},
---
> {image="/data/gfx/shockbolt/npc/patrol_allied_kingdoms_allied_kingdoms_halfling_patrol.png", text=[[The Nargol empire was once the largest force in Maj'Eyal, but a combination of the Spellblaze and orcish attacks have reduced it to insignificance.]]},
104c104
< {image="/data/gfx/shockbolt/object/artifact/jewelry_ring_of_the_dead.png", text=[[It's said that some rare powers can save your soul from the edge of death.]]},
---
> {image="/data/gfx/shockbolt/object/artifact/jewelry_ring_of_the_dead.png", text=[[It's said that some rare powers can save one's soul from the edge of death.]]},
107c107
< {image="/data/gfx/shockbolt/terrain/worldmap.png", text=[[Maj'Eyal is the biggest continent in the world of Eyal. Though records suggest other continents and islands may exist it has not been possible to cross the wide and stormy oceans since the Spellblaze and the Cataclysm.]]},
---
> {image="/data/gfx/shockbolt/terrain/worldmap.png", text=[[Maj'Eyal is the biggest continent in the world of Eyal. Although records suggest that other continents and islands may exist, it has not been possible to cross the wide and stormy oceans since the Spellblaze and the Cataclysm.]]},
111c111
< {image="/data/gfx/shockbolt/npc/humanoid_shalore_elven_corruptor.png", text=[[Corrupters fed off the essence of others, and can use their own corrupted blood to launch deadly magical attacks.]]},
---
> {image="/data/gfx/shockbolt/npc/humanoid_shalore_elven_corruptor.png", text=[[Corrupters feed off the essence of others, and can use their own corrupted blood to launch deadly magical attacks.]]},
for t, v in pairs(self.resists) do
if t ~= "all" then v = self:combatGetResist(t) end
if v ~= 0 then resists[#resists+1] = string.format("%d%% %s", v, t == "all" and "all" or DamageType:get(t).name) end
end
for t, v in pairs(self.resists) do
if v ~= 0 then
if t ~= "all" then v = self:combatGetResist(t) end
resists[#resists+1] = string.format("%d%% %s", v, t == "all" and "all" or DamageType:get(t).name)
end
end
that's because resist can be 0 but combatGetResist can return a value >0.
It happen when resist[dmgType]==0 and resist[all]>0 so that combatGetResist(dmgType)==resist[all].
In that case you have (example data): "Resists: all 10%, cold 10%" instead of (the correct one, in my opinion) "Resists: all 10%"
Just a note: I found that the "off-balance" description has a double %:
long_desc = function(self, eff) return ("Badly off balance. Global speed is reduced by 15%%.") end
