[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 483: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 483: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 483: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 483: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 483: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 483: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 483: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 483: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 483: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 483: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 483: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 483: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 483: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 483: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 483: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 483: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 483: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 483: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 483: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 483: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 483: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 483: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 483: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 483: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 483: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 483: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 112: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 112: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 112: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 112: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 112: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 112: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/bbcode.php on line 112: preg_replace(): The /e modifier is no longer supported, use preg_replace_callback instead
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 4752: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3887)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 4754: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3887)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 4755: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3887)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 4756: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3887)
ToME: the Tales of Maj'Eyal • View topic - ToME 2 maintenance

ToME: the Tales of Maj'Eyal

Everything about ToME
It is currently Tue Apr 13, 2021 11:51 am

All times are UTC




Post new topic Reply to topic  [ 326 posts ]  Go to page Previous  1 ... 17, 18, 19, 20, 21, 22  Next
Author Message
 Post subject: Re: ToME 2 maintenance
PostPosted: Sat Oct 24, 2015 6:19 pm 
Offline
Uruivellas

Joined: Tue Dec 13, 2005 12:35 am
Posts: 712
Yeah, I figured that out, sorry. :oops: Looks like something you deprecated.


Top
 Profile  
 
 Post subject: Re: ToME 2 maintenance
PostPosted: Sat Oct 24, 2015 6:22 pm 
Offline
Spiderkin

Joined: Sat Mar 18, 2006 12:48 pm
Posts: 482


Last edited by AnonymousHero on Sat Oct 24, 2015 6:24 pm, edited 1 time in total.

Top
 Profile  
 
 Post subject: Re: ToME 2 maintenance
PostPosted: Sat Oct 24, 2015 6:24 pm 
Offline
Uruivellas

Joined: Tue Dec 13, 2005 12:35 am
Posts: 712
Good point. :oops:

Meanwhile, Linux SSP is actually getting invoked no matter what one enters on the Automizer prompt. Hmm.


Top
 Profile  
 
 Post subject: Re: ToME 2 maintenance
PostPosted: Sat Oct 24, 2015 6:54 pm 
Offline
Uruivellas

Joined: Tue Dec 13, 2005 12:35 am
Posts: 712
The buffer overrun here, wherever it is, seems to have been present at least since the introduction of the new jansson-based Automizer. Maybe earlier.

Edit: right, git bisect. D'oh!

Edit: yeah, 2.3.9-ah works. Let's start bisecting.


Top
 Profile  
 
 Post subject: Re: ToME 2 maintenance
PostPosted: Sat Oct 24, 2015 7:28 pm 
Offline
Uruivellas

Joined: Tue Dec 13, 2005 12:35 am
Posts: 712
Alright, the first bad commit is 6add91e17080e06cae938a31c53c94e59c7f0bfb.

This commit basically contains the entirety of the jansson-based automizer code, almost as it appears today. :(


Top
 Profile  
 
 Post subject: Re: ToME 2 maintenance
PostPosted: Sun Oct 25, 2015 7:56 pm 
Offline
Uruivellas

Joined: Tue Dec 13, 2005 12:35 am
Posts: 712


Top
 Profile  
 
 Post subject: Re: ToME 2 maintenance
PostPosted: Sun Oct 25, 2015 8:09 pm 
Offline
Uruivellas

Joined: Tue Dec 13, 2005 12:35 am
Posts: 712
I added another assert before the 'if' statement, and it's obviously a null pointer before the 'if' is reached. Hmm.


Top
 Profile  
 
 Post subject: Re: ToME 2 maintenance
PostPosted: Sun Oct 25, 2015 8:18 pm 
Offline
Uruivellas

Joined: Tue Dec 13, 2005 12:35 am
Posts: 712
Wait wait wait! display_condition is recursive, so it must be nullifying the pointer somewhere. Just a minute.


Top
 Profile  
 
 Post subject: Re: ToME 2 maintenance
PostPosted: Sun Oct 25, 2015 8:25 pm 
Offline
Uruivellas

Joined: Tue Dec 13, 2005 12:35 am
Posts: 712
Okay, I think I got this. The M_NOT case in display_condition() is invoking the function recursively on condition->subcondition, which is explicitly NULL. (Line 2219 in squeltch.c.) Let's see what happens when we check for that being NULL too.

Edit: That works. I'll look over it for further invocations without NULL checking, then request a merge. (With apologies for the last merge request.)


Top
 Profile  
 
 Post subject: Re: ToME 2 maintenance
PostPosted: Mon Oct 26, 2015 1:08 pm 
Offline
Uruivellas

Joined: Tue Dec 13, 2005 12:35 am
Posts: 712


Top
 Profile  
 
 Post subject: Re: ToME 2 maintenance
PostPosted: Mon Oct 26, 2015 1:38 pm 
Offline
Uruivellas

Joined: Tue Dec 13, 2005 12:35 am
Posts: 712
Okay - all three of those are in my automizer-fix branch, and I've filed a merge request. :)


Top
 Profile  
 
 Post subject: Re: ToME 2 maintenance
PostPosted: Sat Oct 31, 2015 1:24 pm 
Offline
Uruivellas

Joined: Tue Dec 13, 2005 12:35 am
Posts: 712


Top
 Profile  
 
 Post subject: Re: ToME 2 maintenance
PostPosted: Sat Oct 31, 2015 1:26 pm 
Offline
Spiderkin

Joined: Sat Mar 18, 2006 12:48 pm
Posts: 482


Top
 Profile  
 
 Post subject: Re: ToME 2 maintenance
PostPosted: Sat Oct 31, 2015 1:28 pm 
Offline
Uruivellas

Joined: Tue Dec 13, 2005 12:35 am
Posts: 712
This was with GCC (4.8.2).

BTW this is stuff related to the Straight Road (i.e. Zangband Pattern). Straight Road vaults don't even exist any more. It can probably be removed.

Edit: whoops, and that line is for Wizard Mode anyway.

Edit 2: I just modified the printf invocation to not provide any coordinates (i.e. no %d).

Though, I'm gonna take a look at the vaults info file. I want to see if I can reintroduce Straight Road vaults.


Last edited by Lord Estraven on Sat Oct 31, 2015 1:33 pm, edited 1 time in total.

Top
 Profile  
 
 Post subject: Re: ToME 2 maintenance
PostPosted: Sat Oct 31, 2015 1:30 pm 
Offline
Spiderkin

Joined: Sat Mar 18, 2006 12:48 pm
Posts: 482


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 326 posts ]  Go to page Previous  1 ... 17, 18, 19, 20, 21, 22  Next

All times are UTC


Who is online

Users browsing this forum: No registered users and 2 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group